Fusion4Energy / F4Enix

API for parsing and post-processing many MC simulations related files
Other
12 stars 10 forks source link

Also testing linux OS with PR to developing branch #74

Closed shimwell closed 5 months ago

shimwell commented 5 months ago

Description

We currently test Windows OS when making a PR to developing branch but we don't test linux. This PR is a tiny change so that we test linux as well. Feel free to reject if this preference for windows testing is by design, I wasn't sure so I though I should make the PR

Checklist:

dodu94 commented 5 months ago

No problem with this, especially since we saw now that dev is broken for linux. The fix is easy, you can do it directly in this branch, no need to open a new one to just change the file paths.

shimwell commented 5 months ago

I've now fixed the path by removing D:/ and the next error is ...

UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 33828: ordinal not in range(128)

So I shall go through the notebooks and check they are UTF-8

shimwell commented 5 months ago

Just to mention these tests work locally on my ubuntu computer and on wsl ubuntu. I shall look into this more soon. Currently priority is the nuc data plotting

dodu94 commented 5 months ago

Specifying utf-8 encoding while opening the jupyter seems to have solved the issue. I'll go ahead and merge the PR

shimwell commented 5 months ago

nice work @dodu94 thanks for finishing the PR