search

FusionAuth / fusionauth-client-builder

The FusionAuth client library builder
https://fusionauth.io/
Apache License 2.0
6 stars 24 forks source link

fix: define string values for enums #14

Closed jfairley closed 4 years ago

jfairley commented 4 years ago

Defines default values for TypeScript enums.

See https://github.com/FusionAuth/fusionauth-typescript-client/pull/25

I'm not sure how to test this, so I haven't. Just trying to help out where I can.

jfairley commented 4 years ago

I just noticed that client library release versions correspond to the fusionauth core versioning, so I see I'm in there with all the other issues across the ecosystem.

When can I expect this one to go in? Do I need to get votes?

mooreds commented 4 years ago

@jfairley thanks! I'll take a look.

mooreds commented 4 years ago

This doesn't appear to affect usage based on testing (I tested it by building the typescript client locally with the change, then reading and modifying the LogoutBehavior value of the OauthConfiguration of an application via the typescript client id), so it looks fine to me to merge.

jfairley commented 4 years ago

🎊