search

FusionAuth / fusionauth-client-builder

The FusionAuth client library builder
https://fusionauth.io/
Apache License 2.0
6 stars 24 forks source link

Added code verifier as a parameter. #18

Closed mooreds closed 3 years ago

mooreds commented 4 years ago

This allows using PKCE code verifier with the client libs.

Fixes issue #17 .

I tested building the java and php client libs, and things looked ok. It compiled.

Wasn't sure quite how to make it optional, looked through https://github.com/inversoft/client-library-plugin/ but didn't see it.

robotdan commented 4 years ago

For typed languages, this will be a compile break. That may be ok, it shouldn't be too hard to fix. One option is to make a new method for use with PKCE to make it more explicit and to not break the existing client method.

I could go either way. In general I would prefer not to break compile if we don't have to, in this case it may not be too bad to just add another method.

exchangeOAuthCodeForAccessTokenUsingPKCE or something like that?

mooreds commented 4 years ago

That makes sense. I'll add another json file with that name and the new params.

mooreds commented 3 years ago

@robotdan can I get a quick review on this? It's blocking @amans330 's PKCE work.

robotdan commented 3 years ago

Added comments.

mooreds commented 3 years ago

@robotdan you comfortable with this as it is now? Would love to get this included in the next point release.