search

FusionAuth / fusionauth-client-builder

The FusionAuth client library builder
https://fusionauth.io/
Apache License 2.0
6 stars 24 forks source link

Use fetch API instead of request package #2

Closed tjpeden closed 4 years ago

tjpeden commented 4 years ago

credentials settings for fetchI added a function that would allow users of the client to set how they want cookies sent with in all requests.

I also added the return type to the previous function that was added, thanks @fdaugs and @robotdan for that!

Lastly, refactored the constructor which, when compiled, resulted in duplicate code.

tjpeden commented 4 years ago

Any update on this?

robotdan commented 4 years ago

Hey @tjpeden , sorry, been swamped. The title mentions using fetch instead of the request package, is that in a different commit or am I just blind and not seeing it in this commit?

I just need to review this with @tyduptyler13 and if it looks good we can approve. I appreciate your contribution!

tjpeden commented 4 years ago

It's in the matching PR: https://github.com/FusionAuth/fusionauth-typescript-client/pull/6

robotdan commented 4 years ago

Thanks for your contribution!