FusionAuth / fusionauth-client-builder

The FusionAuth client library builder
https://fusionauth.io/
Apache License 2.0
6 stars 24 forks source link

Openapi yaml #41

Closed mooreds closed 2 years ago

mooreds commented 2 years ago

This is a first pass at generating an openAPI yaml file from the API and domain JSON files.

This deploys files to the https://github.com/FusionAuth/fusionauth-openapi repository, where it can be versioned and released like any other client library package (not quite sure how the release plugin works, so I just copy pastaed it).

There are some flaws in the implementation. While the specification is valid, the generated client libraries haven't been fully exercised.

In particular:

Rollout plan:

voidmain commented 2 years ago

It's a lot of code to digest, but the first thing that jumped out was that the instants don't look to be correctly handled. We use integers for all instants (ZonedDateTime) and they represent the number of milliseconds since Epoch.

mooreds commented 2 years ago

Okay, let me take another pass and re-request code review.