search

FusionAuth / fusionauth-client-builder

The FusionAuth client library builder
https://fusionauth.io/
Apache License 2.0
6 stars 24 forks source link

Repository Stutter #6

Closed GrimTheReaper closed 4 years ago

GrimTheReaper commented 4 years ago

I've noticed that all of the client library repositories start with fusionauth. In languages like go, this leads to package stuttering (fusionauth/fusionauth-go-client). Any reason why it shouldn't just be {language}-client?

robotdan commented 4 years ago

@GrimTheReaper this is just our pattern thus far.

@matthew-altman Any potential issues you see with a change such as this?

matthew-altman commented 4 years ago

@robotdan It's a matter of renaming every client repo. Not hard, but there would be a lot of downstream repo changes as well...maven, npm, etc

robotdan commented 4 years ago

@matthew-altman what about just for Go, is the package stuttering an issue with Go?

matthew-altman commented 4 years ago

@robotdan No problem changing it for Go. It's not an issue, per se, but isn't idiomatic. I'll see what I can do.

matthew-altman commented 4 years ago

This has been resolved. Github automatically creates redirects for renamed repos, so existing usages should still be fine. The README in the go-client repo has an updated example that shows it cleaned up as well.

robotdan commented 4 years ago

@matthew-altman just in case... make sure you also update the Go doc page. https://fusionauth.io/docs/v1/tech/client-libraries/go

GrimTheReaper commented 4 years ago

Neat. The only other weird oddity for the Go package is that everything is under pkg. Usually, if a repo is just a library and not an application, the resources are under root. A good(ish) example can be found here, although I wouldn't say that it is important enough to break existing changes.

Also while I was glancing about, I noticed that the README example has invalid go syntax, so I fixed that for you https://github.com/FusionAuth/go-client/pull/10

robotdan commented 4 years ago

Thanks @GrimTheReaper the help is appreciated!

@matthew-altman can you take a look at these issues, perhaps open another issue to track.