search

FusionAuth / fusionauth-client-builder

The FusionAuth client library builder
https://fusionauth.io/
Apache License 2.0
6 stars 24 forks source link

Adds a default timeout #7

Closed GrimTheReaper closed 4 years ago

GrimTheReaper commented 4 years ago

If a default http client is used in place of a provided one, you might want to ensure that it has a timeout. http.DefaultClient has no timeout, and under certain events could possibly deadlock. There are one or two other things that should probably be touched up, but this one sticks out to me the most.

While I put in 5 minutes, feel free to change it to however long you think is appropriate for a default.

matthew-altman commented 4 years ago

@GrimTheReaper Thanks for the PR