FusionAuth / fusionauth-typescript-client

A TypeScript client for FusionAuth
https://fusionauth.io
Apache License 2.0
60 stars 27 forks source link

Issue with domain sync #84

Open glen-84 opened 1 year ago

glen-84 commented 1 year ago

This change keeps on occurring, making it difficult to keep track of revisions in the commit log.

https://github.com/FusionAuth/fusionauth-typescript-client/commit/ce70451ebc66e54ea2ab77d0d0742bbc004d2e3d https://github.com/FusionAuth/fusionauth-typescript-client/commit/8238bd8b6e177dddd1ed04254997f622338949f4

mooreds commented 1 year ago

Hiya @glen-84 ,

This is part of every release, because the typescipt client is generated from a number of configuration files. All of this is currently managed through this project: https://github.com/FusionAuth/fusionauth-client-builder

Are there specifics that would make these changes easier that you can share?

Thanks!

glen-84 commented 1 year ago

I understand that the client is generated, I'm suggesting that there may be an issue with the generator, because it keeps generating the exact same change.

More examples:

https://github.com/FusionAuth/fusionauth-typescript-client/commit/ccbc819f5cbff2a1d139d6f9c88d4f991e1c789c https://github.com/FusionAuth/fusionauth-typescript-client/commit/0b23cd09980864f394d42ede529ba15feb58daed https://github.com/FusionAuth/fusionauth-typescript-client/commit/37166bf1daafa05748b43efb472553cdb405dabf

glen-84 commented 1 year ago

It looks like the same interface is being exported 3 times.

https://github.com/FusionAuth/fusionauth-typescript-client/blob/5571ccf3cc3691cdf67242d2466053540c6bd1d9/src/FusionAuthClient.ts#L7845-L7857

mooreds commented 1 year ago

Ah, thank you Glen for the further explanation. That does look like an issue with the codegen tool. I can see how that would be annoying. I filed an issue: https://github.com/FusionAuth/fusionauth-issues/issues/2034

Just to confirm, there's no functional bug when trying to use the lambda configuration, correct?

glen-84 commented 1 year ago

I'm not aware of any functional bugs, but I'm also not using that interface myself.