Configurable resource - And more.

FusionWorks / react-admin-nestjsx-crud-dataprovider

Data provider which integrates React Admin with NestJS CRUD library

132 stars 26 forks source link

Configurable resource - And more. #11

Open Bnaya opened 5 years ago

Bnaya commented 5 years ago

Impalements #9 fixes #9 The readme changes will explain the best.

Adds ability to configure joins/selects per resource/reference.
Fetch full and fresh copy of the record after create and update (More correct behaviour for RA expectations)
use prettier, typescript and other infra changes.
Some tests

Bnaya commented 5 years ago

A published version of it: https://www.npmjs.com/package/bnaya_fork_ra-data-nest-crud

Bnaya commented 5 years ago

This kind of code is impossible to strictly type. The objects we are dealing with are very dynamic. Adding some local types in some spots is more personal flavour than technical fact.

Bnaya commented 5 years ago

I really appreciate your time reviewing this PR, But the review is missing the whole point of the PR, and not really valuable. Giving generic comments about code style, that are also arguable, Is not really helpful.

There are very good reasons here to use ts-ignore and any And if you have any style rules to follow, please, lets add eslint config with them.

I expect questions on the implementation details and the api, And suggestions how to make it better.