Futura-Py / Notes

The modern text editor written in python
MIT License
9 stars 2 forks source link

REWRITE #77

Open not-nef opened 1 year ago

not-nef commented 1 year ago

complete rewrite from the ground up with oop and good this time

help much appreciated

why is the file diff so ducked up

sumeshir26 commented 1 year ago

Whats the point of the StartupWindow?

not-nef commented 1 year ago

It is the Startup Window where you can select create new file, open file, etc. its just not complete yet.

not-nef commented 1 year ago

It is the Startup Window where you can select create new file, open file, etc. its just not complete yet.

Also i will add things like recently opened files there later

not-nef commented 1 year ago

you guys were so right oop is so cool

not-nef commented 1 year ago

It is the Startup Window where you can select create new file, open file, etc. its just not complete yet.

Also i will add things like recently opened files there later

nevermind i got rid of it

im-coder-lg commented 1 year ago

@not-nef need your insight on this review! https://github.com/Futura-Py/Notes/pull/77#discussion_r1311902140

not-nef commented 1 year ago

idk what you want me to look at, that hyperlink does nothing for me

im-coder-lg commented 1 year ago

@not-nef I meant this in that link: https://github.com/Futura-Py/Notes/blob/66cd993927852cf8587faf3d7afb43572e905004/docs/README.md?plain=1#L13

Aren't we supposed to change that?

not-nef commented 1 year ago

yeah i will change that in this pr, a lot needs to be redone in this repo

not-nef commented 1 year ago

most docs files are out of date

not-nef commented 1 year ago

linux is really starting to grow on me but i cant switch because i wont be able to play most of my video games anymore :(

not-nef commented 1 year ago

you know what, im just gonna make a seperate windows partition for my games and switch to linux.

not-nef commented 1 year ago

my new motherboard should be arriving today so i am very excited.

not-nef commented 1 year ago

great they sent me back my old motherboard and said that it works fine. now i have no idea what is wrong

im-coder-lg commented 1 year ago

@not-nef the Proton compatibility layer on Steam works fine. You can use Bottles(on Flathub) to add game clients like Epic! Games, Steam, etc. I use normal Steam for Linux, but I added a command for my games so that when it launches, it actually loads. There is an issue with Proton that does this, but this additional command would work. Try that, and if it doesn't work, I'll put the command here. Can't boot my PC as of now, I got a lot of work to do.

not-nef commented 1 year ago

That sounds cool i will definitely try that

im-coder-lg commented 1 year ago

great they sent me back my old motherboard and said that it works fine. now i have no idea what is wrong

I wonder if it is with your RAM maybe? They said it is all right, but my guess is that the memory went to hell. It might be the RAM or the ROM.

not-nef commented 1 year ago

that was also what i thought, but i dont that that both ram sticks would break at the same time, and i read that the ryzen 7000 series has some issues with the bios and the voltage, so i currently think its my cpu, i think i will also try to send it back but lets see what the company replies

not-nef commented 1 year ago

i got my games and even my mods to work with proton and bottles. i am 100% switching to linux now

sumeshir26 commented 1 year ago

i got my games and even my mods to work with proton and bottles. i am 100% switching to linux now

Which distro do you use?

not-nef commented 1 year ago

mint cinnamon

not-nef commented 1 year ago

What do yall think about standardizing our icons?:

97777018

sumeshir26 commented 1 year ago

What do yall think about standardizing our icons?:

97777018

Looks Nice to me, What if we change the colours of the triangles to distinguish further?

not-nef commented 1 year ago

yeah we could

not-nef commented 1 year ago

but you would have to send me the source file because if i would edit it like that, the shade would be gone

im-coder-lg commented 1 year ago

What do yall think about standardizing our icons?:

97777018

This. Is. Bloody. Delectable.

I LOVE THIS TYPE!

We gotta make Weather one of these icons. @sumeshir26 don't get me wrong, your icon was good, but we have to design this the same way we designed the org display image. It looks good with our trails behind. Maybe we can add it into the apps? The Easter egg we have been waiting for might be here.

sumeshir26 commented 1 year ago

What do yall think about standardizing our icons?: 97777018

This. Is. Bloody. Delectable.

I LOVE THIS TYPE!

We gotta make Weather one of these icons. @sumeshir26 don't get me wrong, your icon was good, but we have to design this the same way we designed the org display image. It looks good with our trails behind. Maybe we can add it into the apps? The Easter egg we have been waiting for might be here.

Sure, I will design a similar icon for weather. But, should I keep the same colours or different ones?

im-coder-lg commented 1 year ago

Hmm, let's try that. Sure, let's see how that works.

not-nef commented 1 year ago

i am speed 977770183

not-nef commented 1 year ago

btw those icons were freestyled, if you decide to keep them, i will redo them with more effort (align the logo, unique colors etc)

sumeshir26 commented 1 year ago

Looks good to me!

im-coder-lg commented 1 year ago

i am speed 977770183

Ha! The one we need. I think it could use a bit of polishing, as you said.

not-nef commented 1 year ago

okay, will do as soon as i get home (im going boating today :D)

not-nef commented 1 year ago

icon submission

weather_final

sumeshir26 commented 1 year ago

icon submission

weather_final

Looks nice! Can you do similar for the notes icon?

not-nef commented 1 year ago

i think i am gonna do a black and white one for notes but i have to see about the visibility from the taskbar

not-nef commented 1 year ago

god damnit i really thought i would be happy with linux, but here are the reasons i will switch back to linux:

im fed up i am going back to windows bye mint

im-coder-lg commented 1 year ago

Maybe you can try Pop!_ OS, it has System76's official NVIDIA driver, if that is your GPU. It also supports AMD GPU and has a driver for that too, if I am not wrong.

not-nef commented 1 year ago

might look at it in the future but currently i just miss me windows :(

im-coder-lg commented 1 year ago

Okay, but try Pop!_ OS later. I did, it is neat and all that, but I again broke the OS. Eventually landing on Manjaro Gnome and finally back to Zorin.

not-nef commented 1 year ago

i have no idea why but the app is lagging like crazy on windows

im-coder-lg commented 1 year ago

Intrigues me. Well, I am assuming that you are talking about the editor, so it could be due to extensions if it is VS Code. If it is Notes, I believe that you have too many processes online, so open the task manager and find out the useless ones, then end them. I used to do that before, on Windows 7. Yeah, Windows 10 crashed, I got the PC fixed with Windows 7, and now I'm on Linux.

not-nef commented 1 year ago

i am talking about the program itself, and even after a fresh reboot this thing is lagging like crazy

im-coder-lg commented 1 year ago

Huh. Well, that is odd. Let me check on Gitpod. Maybe if I see it too, we have to find a way to debug the app. Wait have you run debugging from VS Code? It does seem useless, but we might be able to find out what happened. Might, not will. Could hint us, y'know.

im-coder-lg commented 1 year ago

We gotta update the branch.

im-coder-lg commented 1 year ago

@not-nef you added TkFileBrowser to the code. It's not there in requirements.txt yet, maybe?

not-nef commented 1 year ago

yes, because i will most likely add more packages and will update requirements.txt before merging the branch

im-coder-lg commented 1 year ago

Okay, so what about a Gitpod config? I need to add it just for configuring the image to load with VNC preview enabled. It uses Docker, so there would be an issue with that.

im-coder-lg commented 1 year ago

We wouldn't need it much, yes, but if anybody were to test on the fly, it might help. I'm not coding anything on my local computer since Zorin and Python seem to be at odds right now.

not-nef commented 1 year ago

so the app is lagging like crazy, but the tkfilebrowser instance inside of it is running smooth as ever. something is clearly not right