Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

Use Sun Valley Entry Box #17

Closed not-nef closed 2 years ago

not-nef commented 2 years ago

i only tested this on macos so you should maybe see how it looks on windows

im-coder-lg commented 2 years ago

Can you send a screenshot of the preview? I mean, clone your fork of TimerX, install all requirements, start the app and take a screenshot, so that we could know what to expect and what not to expect.

not-nef commented 2 years ago

Sure!

image

not-nef commented 2 years ago

i deleted my fork to open another pr is that bad?

sumeshir26 commented 2 years ago

@not-nef Hi! Thank you so much for opening this PR, I wanted to do this since forever, but other things came in the way. In the future, instead of deleting forks, try making branches so you can make multiple PRs properly. Ialso did this mistake the first tome I opened a PR. Thabk you, I will merge when I get on my Pc today or tommorow

im-coder-lg commented 2 years ago

That's good, well do a final test and then @sumeshir26 can merge.

not-nef commented 2 years ago

@not-nef Hi! Thank you so much for opening this PR, I wanted to do this since forever, but other things came in the way. In the future, instead of deleting forks, try making branches so you can make multiple PRs properly. Ialso did this mistake the first tome I opened a PR. Thabk you, I will merge when I get on my Pc today or tommorow

I tried making a branch for the banner pr, but it also contained the commits for this pr

im-coder-lg commented 2 years ago

Hmm... Can you grant me collaborator access to your fork? Maybe I could help.

im-coder-lg commented 2 years ago

I know what the problem is as well as the solution. First, I'll test, then I'll go ahead with my plan.

not-nef commented 2 years ago

Hmm... Can you grant me collaborator access to your fork? Maybe I could help.

That fork no longer exists lmao

not-nef commented 2 years ago

i only have the fork for the banner pr

im-coder-lg commented 2 years ago

Grant me collaborator access to that, I'll manage the rest :wink:

not-nef commented 2 years ago

oke, gimme a sec

not-nef commented 2 years ago

done

not-nef commented 2 years ago

@im-coder-lg

im-coder-lg commented 2 years ago

I have a good idea, working on that now.

not-nef commented 2 years ago

cool

im-coder-lg commented 2 years ago

@not-nef close this PR, we'll manage this in #18