Closed not-nef closed 2 years ago
Can you send a screenshot of the preview? I mean, clone your fork of TimerX, install all requirements, start the app and take a screenshot, so that we could know what to expect and what not to expect.
Sure!
i deleted my fork to open another pr is that bad?
@not-nef Hi! Thank you so much for opening this PR, I wanted to do this since forever, but other things came in the way. In the future, instead of deleting forks, try making branches so you can make multiple PRs properly. Ialso did this mistake the first tome I opened a PR. Thabk you, I will merge when I get on my Pc today or tommorow
That's good, well do a final test and then @sumeshir26 can merge.
@not-nef Hi! Thank you so much for opening this PR, I wanted to do this since forever, but other things came in the way. In the future, instead of deleting forks, try making branches so you can make multiple PRs properly. Ialso did this mistake the first tome I opened a PR. Thabk you, I will merge when I get on my Pc today or tommorow
I tried making a branch for the banner pr, but it also contained the commits for this pr
Hmm... Can you grant me collaborator access to your fork? Maybe I could help.
I know what the problem is as well as the solution. First, I'll test, then I'll go ahead with my plan.
Hmm... Can you grant me collaborator access to your fork? Maybe I could help.
That fork no longer exists lmao
i only have the fork for the banner pr
Grant me collaborator access to that, I'll manage the rest :wink:
oke, gimme a sec
done
@im-coder-lg
I have a good idea, working on that now.
cool
@not-nef close this PR, we'll manage this in #18
i only tested this on macos so you should maybe see how it looks on windows