feat: Dark mode

[sumeshir26]

@im-coder-lg Can you test on Zorin OS

[im-coder-lg]

I haven't switched yet. Yeah I need permission to switch and it's best done on a Sunday, but I could try Raspbian.

[sumeshir26]

@im-coder-lg could you try on your pi?

[im-coder-lg]

Well I'll do it soon, maybe by tonight since I got some work to do.

[im-coder-lg]

Have you added a toggle for dark mode here?

[im-coder-lg]

It fails at the icon script... Maybe instead of linux we need to use aarch64 or armv7l for Raspberry Pi users, and amd64, arm64 for 64-bit systems.

[im-coder-lg]

It's the JPEG that disturbs btw

[im-coder-lg]

You don't need to remove the already-existing builds. I saw that Ubuntu succeded, but WIndows, it doesn't know what rm is. I will experiment on this and make sure the checks succeed.

[sumeshir26]

Have you added a toggle for dark mode here?

No, it should detect the system theme via darkdetect

[im-coder-lg]

Couldn't experiment checks but I am going to switch to Zorin soon so you have a Linux+Windows(Windows App Support) tester here, but the checks issue, maybe I will edit and send a PR to dark-mode.

[sumeshir26]

@im-coder-lg I asked you to test on zor in because I know tha zorin had a dark mode and I wanted to test dark mode detection on zorin

[im-coder-lg]

Did it work on Windows? As of now, I think it will fail(Linux btw) due to the icon(JPEG didn't seem to work on Raspbian) but let's see, it would take a lot of time to switch to Zorin.

[sumeshir26]

It does work on Windows 11 but dark mode on Linux is kind weird because of the many distros

[sumeshir26]

@im-coder-lg Try now

[im-coder-lg]

Dude I don't have Zorin installed yet! It might work so just comment out the Linux platform code, it seems to disturb the run.

[im-coder-lg]

I think I could do the test tomorrow/Sunday. Flashing time, going into the boot meny, and till it's successfully installed, it will take a lot of time. But what about Gitpod+Xrdp+Xfce desktop? Till I get Zorin?

[sumeshir26]

@im-coder-lg I’ll try… I will try on replit first

[im-coder-lg]

Wow. I'll be gone for long, I think I'll be finally getting Zorin. Before the installation(which is due evening), however, I'll check on my Win7 PC.

[sumeshir26]

@im-coder-lg Nope?

[im-coder-lg]

Woah, massive bug? Windows 10 also has 32-bit apps, so why not make the change? I have used Windows 10 for a few years, and I got this new PC(well not new, kinda 10 years old) but the dark mode does work. Although it moves the layout a bit, it works fine. We must find out if Windows 11 supports 32-bit apps or we could just change it to win. What do you think?

[sumeshir26]

@im-coder-lg Windows 11 does support 32 bit apps but does not support 32 bit PCs

[sumeshir26]

@im-coder-lg Try now

[im-coder-lg]

Well, voila. We can use win32 as the code. Windows 11 uses win32 apps but not win32 systems... We can use win32.

[im-coder-lg]

And don't use caps for the system code. Darwin might render as invalid but darwin won't.

[im-coder-lg]

2 minutes please.

[im-coder-lg]

Windows failed. Console logs:

$ python main.py
  File "main.py", line 19
    elif  platform.system() == "darwin":
    ^
SyntaxError: invalid syntax

PS: Using Git Bash since I am a Bash enthusiast.

[sumeshir26]

@im-coder-lg Alreaday fixed. Try again

[im-coder-lg]

Seems to work and use the JPEG at the same time... Anyway, I'm switching soon, so this ain't much of a problem.

[im-coder-lg]

Great!