Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

Request to merge `configurator.py` and `main.py` #24

Closed not-nef closed 2 years ago

not-nef commented 2 years ago

If we dont do that, we cant change the theme in the settings window because of circular imports. pls give permission to merge the scripts. thx

not-nef commented 2 years ago

To make sure the code isnt too messy i made this: Screenshot 2021-12-25 103410

im-coder-lg commented 2 years ago

@not-nef first off, I think it might increase the size of the main.py file, second, it could extend code lines thereby making it too long(I expect a TL;DR for long lines of code) and that could make finding code harder. But, if we are able to make a better link between the main.py and configurator.py, we could be in luck since the files will share data with each other like theming, icons, properties, metadata, etc. What do you think? Also, since the screenshot is too small, can you try posting the code as a public Gist and share the link here? Moreover, I wonder if we merge the configurator and the settings together, or adding a link to settings in the configurator window, any ideas? Edit: Added backticks to the title to avoid confusion between grammar engines, etc.

not-nef commented 2 years ago

@im-coder-lg vscode users can collapse functions for a better overview.

btw we literally cant change the theme in the settings if they are in seperate files. its literally impossible

not-nef commented 2 years ago

https://gist.github.com/not-nef/ed6e612634df8638159e07adf9f1df8f

this is the current main file, it has a settings page with working theme switching ^-^

im-coder-lg commented 2 years ago

btw we literally cant change the theme in the settings if they are in seperate files. its literally impossible

Can you link two files?

im-coder-lg commented 2 years ago

https://gist.github.com/not-nef/ed6e612634df8638159e07adf9f1df8f

That works, but it seems to take some time to load upon starting, but I think it's normal. Plus, icons get synced, and more. Can we make a PR to the settings branch @sumeshir26? 400 lines of code but I think it's worth it! Also, push your local changes to the branch so that @not-nef can get the changes and add those codes to the main file himself. @not-nef can you add a bit more spacing between icons in the settings window? Kinda looks cramped, if you ask me.

im-coder-lg commented 2 years ago

Let's add a toggle for blur(exclusively for Windows) too.

sumeshir26 commented 2 years ago

I cant. I am out of townn so I cant get to my computer currenty

not-nef commented 2 years ago

https://gist.github.com/not-nef/ed6e612634df8638159e07adf9f1df8f

That works, but it seems to take some time to load upon starting, but I think it's normal. Plus, icons get synced, and more. Can we make a PR to the settings branch @sumeshir26? 400 lines of code but I think it's worth it! Also, push your local changes to the branch so that @not-nef can get the changes and add those codes to the main file himself. @not-nef can you add a bit more spacing between icons in the settings window? Kinda looks cramped, if you ask me.

lets move this to the pr

im-coder-lg commented 2 years ago

I cant. I am out of townn so I cant get to my computer currenty

I could help. We could add the toggle exclusively to Windows, maybe through the platform code.

not-nef commented 2 years ago

platform code?

sumeshir26 commented 2 years ago

Platform.system()