Closed not-nef closed 2 years ago
To make sure the code isnt too messy i made this:
@not-nef first off, I think it might increase the size of the main.py file, second, it could extend code lines thereby making it too long(I expect a TL;DR for long lines of code) and that could make finding code harder. But, if we are able to make a better link between the main.py and configurator.py, we could be in luck since the files will share data with each other like theming, icons, properties, metadata, etc. What do you think? Also, since the screenshot is too small, can you try posting the code as a public Gist and share the link here? Moreover, I wonder if we merge the configurator and the settings together, or adding a link to settings in the configurator window, any ideas? Edit: Added backticks to the title to avoid confusion between grammar engines, etc.
@im-coder-lg vscode users can collapse functions for a better overview.
btw we literally cant change the theme in the settings if they are in seperate files. its literally impossible
https://gist.github.com/not-nef/ed6e612634df8638159e07adf9f1df8f
this is the current main file, it has a settings page with working theme switching ^-^
btw we literally cant change the theme in the settings if they are in seperate files. its literally impossible
Can you link two files?
https://gist.github.com/not-nef/ed6e612634df8638159e07adf9f1df8f
That works, but it seems to take some time to load upon starting, but I think it's normal. Plus, icons get synced, and more.
Can we make a PR to the settings
branch @sumeshir26? 400 lines of code but I think it's worth it! Also, push your local changes to the branch so that @not-nef can get the changes and add those codes to the main file himself.
@not-nef can you add a bit more spacing between icons in the settings window? Kinda looks cramped, if you ask me.
Let's add a toggle for blur(exclusively for Windows) too.
I cant. I am out of townn so I cant get to my computer currenty
https://gist.github.com/not-nef/ed6e612634df8638159e07adf9f1df8f
That works, but it seems to take some time to load upon starting, but I think it's normal. Plus, icons get synced, and more. Can we make a PR to the
settings
branch @sumeshir26? 400 lines of code but I think it's worth it! Also, push your local changes to the branch so that @not-nef can get the changes and add those codes to the main file himself. @not-nef can you add a bit more spacing between icons in the settings window? Kinda looks cramped, if you ask me.
lets move this to the pr
I cant. I am out of townn so I cant get to my computer currenty
I could help. We could add the toggle exclusively to Windows, maybe through the platform code.
platform code?
Platform.system()
If we dont do that, we cant change the theme in the settings window because of circular imports. pls give permission to merge the scripts. thx