Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

feat: Dynamic Resizing #40

Closed not-nef closed 2 years ago

not-nef commented 2 years ago

https://user-images.githubusercontent.com/83908932/148544832-132482e6-2862-4b21-8b90-2d1a5522856b.mp4

sumeshir26 commented 2 years ago

@not-nef @im-coder-lg Wait, there are some things I want to add

im-coder-lg commented 2 years ago

Phew! I didn't approve easily, since if it's done in one go, there has to be something else to add, right?

im-coder-lg commented 2 years ago

Also, from now, the best way of committing is from the CLI, use this method:

$ pip install -r requirements-dev.txt # get pre-commit hooks and commitizen
$ pre-commit install
$ git add . # adds everything
$ cz commit
add anything, type of commit, scope(optional), title, description, if it's a breaking change or not, why, etc.
$ git push

The best method by a mile.

not-nef commented 2 years ago

@not-nef @im-coder-lg Wait, there are some things I want to add

ok, just tell me what it is and i add it

netlify[bot] commented 2 years ago

βœ”οΈ Deploy Preview for timerx-app canceled.

πŸ”¨ Explore the source changes: eb714c82787d92bcda1b1f5043c02faaf46a8a4b

πŸ” Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61dd2b1a2946fc0007b565c3

im-coder-lg commented 2 years ago

@sumeshir26 will tell that, also why is Netlify failing?

im-coder-lg commented 2 years ago

I knew(expected) it! We need to change the base folder to docs.

not-nef commented 2 years ago

Well can someone pls tell me what to add fgs

sumeshir26 commented 2 years ago

Is it possible to just change the width of the buttons using .configure(width=)?

not-nef commented 2 years ago

Well, you can do that, but afaik the width parameter adjusts the width and not the general size of the Button.

not-nef commented 2 years ago

So it makes the button wider

sumeshir26 commented 2 years ago

I know, but still that’s better than nothing

not-nef commented 2 years ago

okay, will do that later this day

not-nef commented 2 years ago

https://user-images.githubusercontent.com/83908932/148685109-d7ecc58a-a0b7-48e2-96f4-14d5cba99b73.mp4

not-nef commented 2 years ago

@sumeshir26 @im-coder-lg pls review

im-coder-lg commented 2 years ago

Excellent! Anything else to add?

not-nef commented 2 years ago

Nope, all done

not-nef commented 2 years ago

WOOO πŸŽ‰πŸŽ‰πŸŽ‰

im-coder-lg commented 2 years ago

Wait, can you run isort(available on PyPI)? Just to sort the imports, stack them properly. If not, leave it, it might happen accidentally soon.

im-coder-lg commented 2 years ago

Great!

not-nef commented 2 years ago

@im-coder-lg done (actually thats quite a cool tool tbh)

not-nef commented 2 years ago

Great!

wtf how fast was that

im-coder-lg commented 2 years ago

@im-coder-lg done (actually thats quite a cool tool tbh)

When you enable precommit hooks, it will run every time you commit; you can also try isort *.py to sort all PYs.

im-coder-lg commented 2 years ago

wtf how fast was that

Don't blame me, Vivaldi Mail was fast.

not-nef commented 2 years ago

whats vivaldi mail

im-coder-lg commented 2 years ago

My mail client on my browser. It's Vivaldi, kinda like resource-hogging for me tho.

not-nef commented 2 years ago

@sumeshir26 merge?

not-nef commented 2 years ago

btw school start again tomorrow (for me) so i will have less time to work on TimerX.

:(

im-coder-lg commented 2 years ago

I know, same for me. I'm a teenager too lol. But I can manage school, it's not too hard. Maybe I'll be committing some files during my soon-to-come holidays. But don't worry - I'll try fixing some things and try some crazy Tk things that might end up as a new feature. Maybe I'll start with editing the About page since the TimerX text is too large. Also, I never provided the gist of the app text, so maybe now's the chance for me to make sure I learn something new.

not-nef commented 2 years ago

and @sumeshir26 this time, pls use this commit message.

feat: Dynamic resizing (#40)

So it doesnt list all commits

im-coder-lg commented 2 years ago

I'll just rename the PR? That'd be easier, right?

im-coder-lg commented 2 years ago

So it doesnt list all commits

Actually, it's the merge description.

not-nef commented 2 years ago

I'll just rename the PR? That'd be easier, right?

nah, i just dont want that all commits are listed in the master branch commit

im-coder-lg commented 2 years ago

Nah, i just don't want that all commits are listed in the master branch commit

See, we squash and merge, meaning everything is made into one commit. The merge description would have the commit list.

not-nef commented 2 years ago

I know, same for me. I'm a teenager too lol. But I can manage school, it's not too hard. Maybe I'll be committing some files during my soon-to-come holidays. But don't worry - I'll try fixing some things and try some crazy Tk things that might end up as a new feature. Maybe I'll start with editing the About page since the TimerX text is too large. Also, I never provided the gist of the app text, so maybe now's the chance for me to make sure I learn something new.

Well it doesnt go good for me. Since the start of 8th class ive been a complete E Student and it doesnt seem to get better. Before, i was pretty average. I have a chemistry exam on wednesday and if my grades dont get better i wont make the year. :(

im-coder-lg commented 2 years ago

Well, all the best, hope you do well!

im-coder-lg commented 2 years ago

Well, let's try this. Till you return back on Thursday, well just update the documentation and/or add very minor features related to build. I will just edit the about page, minor change. After you are back, we'll resume. I think this is needed since you are the person with the most Python-related commits(even @sumeshir26 is, but for me, you are more creative than me in regards to Python). I think this is the best way for us to say thank you. Make sure you are well-prepared for that exam and just finish that up! All the best too :)

not-nef commented 2 years ago

Thank you so much ❀️

im-coder-lg commented 2 years ago

I think we will start with merging this PR and then start updating documentation from #42 till Thursday.

sumeshir26 commented 2 years ago

Well it doesnt go good for me. Since the start of 8th class ive been a complete E Student and it doesnt seem to get better. Before, i was pretty average. I have a chemistry exam on wednesday and if my grades dont get better i wont make the year. :(

Good Luck, hope it goes good for you!

im-coder-lg commented 2 years ago

Build fails :\ btw saw this come as mail, I'm still busy

im-coder-lg commented 2 years ago

Wait what? the build fails!

sumeshir26 commented 2 years ago

@im-coder-lg No, that was because of an updated workflow file on sumeshir26:master

im-coder-lg commented 2 years ago

Build failed in PR checks, can you please verify?

im-coder-lg commented 2 years ago

Oh, okay. I must've done the same on the PR too.