Closed im-coder-lg closed 2 years ago
鉁旓笍 Deploy Preview for timerx-app canceled.
馃敤 Explore the source changes: d103e2d1f64f35a3246a531f27ffbbcfa25869d7
馃攳 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61dd398db32fed00079d96ff
WIP
Ah that's me, can you approve me as a reviewer?
Yo i can commit cool
I'll manage from here, can you just supervise?
No offense, I need some help frankly.
Yo i can commit cool
Collaborator rights :sunglasses:
Renamed the title semantically, how's that?
semantically?
The cz c
way? It's semantic.
what does it mean
If you compare Add my own image to my blog
and feat(blog): my own image
, you will say the second one is better than the first. This is semantic committing.
Also @sumeshir26 thanks for approving me as a reviewer.
Is the contributing guide fine? Any changes to add? Link: https://deploy-preview-42--timerx-app.netlify.app/docs/contributing
Can we remove this: https://deploy-preview-42--timerx-app.netlify.app/docs/intro?
No, that's the landing page. We can use it as a welcome page, right>
Browser metadata is irritating. Also, I'll edit the intro page, can you add the homepage link to the README and the repo description?
Ok
Any ideas on the intro page? Need some text that's why.
Can anyone else test c288b78? Also, any other ideas?
I think I will edit the homepage a bit.
@im-coder-lg Look at my review
Where's it?
Right above https://github.com/sumeshir26/TimerX/pull/42#issuecomment-1008549823, there is https://github.com/sumeshir26/TimerX/pull/42#issuecomment-1008544552. Try re-commenting that.
I'll be offline for now, it's school. I'll be back by 2:00 PM IST.
I'm back! Now, I will try adding some screenshots to the homepage. @sumeshir26 when you are free, can you give me a desktop screenshot containing TimerX's main window, the configurator window and the settings window(all open simultaneously please)? I'll add them to the homepage.
I feel like the current image on the README looks nice, it looks cluttered if you open all the windows
Also, can repl.it be added to the contributing guide?
Also, can repl.it be added to the contributing guide?
I'll add that now!
I feel like the current image on the README looks nice, it looks cluttered if you open all the windows
It's for the docs homepage. Or, I think the best thing to do is, you take a windowed screenshot of TimerX and send it here. I'll add it to docs/src/pages/HomepageFeatures.js
.
Make sure there are no borders other than the apps border, kinda like macOS screenshots.
Just one more thing to add, the screenshot.
Also, can we try making a triage table for TimerX? It might be clear to understand and GitHub provides this, unfortunately you need to make a project for your account globally. I will try finding some solution to this though, that would increase productivity.
It alreaday has one: https://github.com/sumeshir26/TimerX/projects/1
But that doesn't have tables, that's why I asked. It shows a board, not a table-like view. I mean that it has to look like an Excel spreadsheet.
Trello offers a GitHub integration as well as tabled organizing of cards. But I think we could use something that's already on GitHub.
I removed the old review, it told that it was pending, so dismissed it with "Resolved".
I have to be changing the footer!
Wait, replit
guide needed!
Hey how do we add custom Unicode emojis to Chrome? Becuase I hopped onto a live BrowserStack device running macOS Monterey, Safari 15.1 and they allowed the emoji.
Oh, it's globally for macOS.
/ping @sumeshir26 can you review please?
@im-coder-lg Did you add the screenshot?
Did you add the screenshot?
No, I will add it later. It seems like we all have a busy schedule. I will be busy till lunchtime.
Starting now.
Merge this PR after my commit on the master branch. CI fails and I know why.
Don't, I need to update docs.
Fixed, ready.
Ready for merge!
For now, it's just the first commit, I'll continue soon, maybe tomorrow.