Closed im-coder-lg closed 2 years ago
✔️ Deploy Preview for timerx-app ready!
🔨 Explore the source changes: 73d68d48d5dcc61b776914f94e63637d9f5f38bc
🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61e51cfe2b6bcd0007058858
😎 Browse the preview: https://deploy-preview-54--timerx-app.netlify.app
From now, no one uses Gitpod except for tests. It's too hard to push. Github's APIs need to fix themselves.
Why does ubuntu build fail? (i have art class rn so i cant talk)
and why is the windows build not starting? Nothing works!
I think it's due to the new tests. Fixing,
@TimerX-App/reviewers time for review
I think the readme should be kept in the root dir
@im-coder-lg 28K Aditions and 8K Deletions??!!
Prettier. I just did npx prettier --write .
from the docs root, never expected that lol.
Why did you delete the README from the docs? GitHub accepted it!
I reallay think we should keep it in root
I reallay think we should keep it in root
Okay, what about contributing.md and code of conduct?
FYI
I hate the package lockfile.
Okay, what about contributing.md and code of conduct?
Those can be kept in the docs folder
Okay, but we can't remove the lockfile, npm
recommends we commit it.
Maybe that's why I hesitated in choosing Prettier. Should have just done npx prettier --write docs/
and the same to src
if you consider the root of documentation docs
as root.
I reallay think we should keep it in root
Why?
IDK, maybe it's easy to edit?
@im-coder-lg Removing the Lockfile and Merging since the lockfile is not really necessary...
Alright, fixed merge conflicts. Ready to merge.
The same thing happened again. Hopefully the same doesn't happen locally.