Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

style(docs): Prettier formatting #54

Closed im-coder-lg closed 2 years ago

im-coder-lg commented 2 years ago

The same thing happened again. Hopefully the same doesn't happen locally.

netlify[bot] commented 2 years ago

✔️ Deploy Preview for timerx-app ready!

🔨 Explore the source changes: 73d68d48d5dcc61b776914f94e63637d9f5f38bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61e51cfe2b6bcd0007058858

😎 Browse the preview: https://deploy-preview-54--timerx-app.netlify.app

im-coder-lg commented 2 years ago

From now, no one uses Gitpod except for tests. It's too hard to push. Github's APIs need to fix themselves.

not-nef commented 2 years ago

Why does ubuntu build fail? (i have art class rn so i cant talk)

not-nef commented 2 years ago

and why is the windows build not starting? Nothing works!

im-coder-lg commented 2 years ago

I think it's due to the new tests. Fixing,

im-coder-lg commented 2 years ago

@TimerX-App/reviewers time for review

sumeshir26 commented 2 years ago

I think the readme should be kept in the root dir

sumeshir26 commented 2 years ago

@im-coder-lg 28K Aditions and 8K Deletions??!!

im-coder-lg commented 2 years ago

Prettier. I just did npx prettier --write . from the docs root, never expected that lol.

im-coder-lg commented 2 years ago

Why did you delete the README from the docs? GitHub accepted it!

sumeshir26 commented 2 years ago

I reallay think we should keep it in root

im-coder-lg commented 2 years ago

I reallay think we should keep it in root

Okay, what about contributing.md and code of conduct?

sumeshir26 commented 2 years ago

FYI image

im-coder-lg commented 2 years ago

I hate the package lockfile.

sumeshir26 commented 2 years ago

Okay, what about contributing.md and code of conduct?

Those can be kept in the docs folder

im-coder-lg commented 2 years ago

Okay, but we can't remove the lockfile, npm recommends we commit it.

im-coder-lg commented 2 years ago

Maybe that's why I hesitated in choosing Prettier. Should have just done npx prettier --write docs/ and the same to src if you consider the root of documentation docs as root.

not-nef commented 2 years ago

I reallay think we should keep it in root

Why?

im-coder-lg commented 2 years ago

IDK, maybe it's easy to edit?

sumeshir26 commented 2 years ago

@im-coder-lg Removing the Lockfile and Merging since the lockfile is not really necessary...

im-coder-lg commented 2 years ago

Alright, fixed merge conflicts. Ready to merge.