search

Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

Add better settings #62

Closed not-nef closed 2 years ago

not-nef commented 2 years ago

@sumeshir26 This is ready for merging

netlify[bot] commented 2 years ago

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: e586b462220b41fa75183c5075901e499ece7fa6

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61ed6d13fb56bc0007b1966a

not-nef commented 2 years ago

With every pr, this app more looks like a uwp app!

not-nef commented 2 years ago

Lets goo

im-coder-lg commented 2 years ago

Wait, an even better idea on the about page - why not add it as a tab to the settings window? I will try this though.

not-nef commented 2 years ago

Wait, an even better idea on the about page - why not add it as a tab to the settings window? I will try this though.

I will do it, finish your update system @im-coder-lg

not-nef commented 2 years ago

Done! @im-coder-lg

im-coder-lg commented 2 years ago

That's great, but why does the clock font go dark even in dark mode?

im-coder-lg commented 2 years ago

With every pr, this app more looks like a uwp app!

Seems like the installer's the only thing left out though. If we theme that to Sun Valley, it will look great!

not-nef commented 2 years ago

That's great, but why does the clock font go dark even in dark mode?

Oh, have to check

not-nef commented 2 years ago

That's great, but why does the clock font go dark even in dark mode?

What clock font do you mean? Can you send a screenshot?

im-coder-lg commented 2 years ago

One min...

not-nef commented 2 years ago

Everything seems to work for me

im-coder-lg commented 2 years ago

Oh never mind, it's random. So a restart would fix that. Can you check TimerX-App/TimerX-Update-Test#2?

not-nef commented 2 years ago

Ah i see what you mean

im-coder-lg commented 2 years ago

Anyway, leave it. Soon Windows 7 users will have to switch to Windows 10, so doesn't matter as of now.

not-nef commented 2 years ago

Oh never mind, it's random. So a restart would fix that. Can you check TimerX-App/TimerX-Update-Test#2?

I fixed it!

not-nef commented 2 years ago

Anyway, leave it. Soon Windows 7 users will have to switch to Windows 10, so doesn't matter as of now.

Why?

not-nef commented 2 years ago

@im-coder-lg Done!

not-nef commented 2 years ago

@sumeshir26 can i merge?

sumeshir26 commented 2 years ago

Could you rename the notebook to tabview or tabframe because the name notebook is confusing After that, you can merge!

sumeshir26 commented 2 years ago

Merge this as feat: Settings with Tabs

not-nef commented 2 years ago

Okay

not-nef commented 2 years ago

My first merge 🎉

sumeshir26 commented 2 years ago

My first merge 🎉

Yay!

@not-nef From next time you can just create a branch on the main repo, not your fork so it is easy to manage for everyone