search

Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

Theme doesn't load #64

Closed im-coder-lg closed 2 years ago

im-coder-lg commented 2 years ago

Discussed in https://github.com/TimerX-App/TimerX/discussions/63

Originally posted by **not-nef**, January 24, 2022 Yesterday i tried to compile timerx on my pc. It was horrible. The theme didnt load, and the blurring didnt work. If the github actions builds also look like that, we cant release tomorrow

We must fix this before the Republic Day release.

im-coder-lg commented 2 years ago

@sumeshir26 can you please check if the same applies to you? And if you have a fix, can you commit it?

sumeshir26 commented 2 years ago

@im-coder-lg I am facing the same issue. I might know a fix...

sumeshir26 commented 2 years ago

Based on the window, it is the same problem you had in the Blur PR. How did you fix it?

im-coder-lg commented 2 years ago

Who? Me? It was the theme! It works like this: Config is saved. If it's system, it mimics Windows 7, if it's Light or Dark, it uses Blur there. Afaik, dark mode's blur worked better.

not-nef commented 2 years ago

Based on the window, it is the same problem you had in the Blur PR. How did you fix it?

It was fixed in the source code. This has to be an issue with cx_freeze because when starting the app from source it works fine.

not-nef commented 2 years ago

image

I think the highlighted line causes the build to cancel. Does anyone know what it means? @TimerX-App/reviewers

im-coder-lg commented 2 years ago

Hmm... I will test this soon.

sumeshir26 commented 2 years ago

@im-coder-lg How did you fix this: https://github.com/TimerX-App/TimerX/pull/46#issuecomment-1015155905?

im-coder-lg commented 2 years ago

Just switched the theme.

im-coder-lg commented 2 years ago

And also restarted the app.

im-coder-lg commented 2 years ago

I think it's related to the Blur PR. This happens due to DarkDetect. If you set it to System, it will use basic Tk UI with transparency. If you put light or dark mode, it will NOT apply blur and stick with transparency. I think it's due to the -transparency tag in the code.

sumeshir26 commented 2 years ago

@im-coder-lg Yes, now that I set the default theme in utils.py as Light, the issue is fixed. The System option is messed up. We could completely disable the System option until we find a fix.

not-nef commented 2 years ago

When is republic day?

not-nef commented 2 years ago

@im-coder-lg Yes, now that I set the default theme in utils.py as Light, the issue is fixed. The System option is messed up. We could completely disable the System option until we find a fix.

I will do that after school

not-nef commented 2 years ago

I think it's related to the Blur PR. This happens due to DarkDetect. If you set it to System, it will use basic Tk UI with transparency. If you put light or dark mode, it will NOT apply blur and stick with transparency. I think it's due to the -transparency tag in the code.

That seems to happen, but i see no explanation to that. This must be a bug

im-coder-lg commented 2 years ago

When is republic day?

26 Jan in India. Wikipedia will tell you more about the specialty. Also, I think we shouldn't use Darkdetect, that was the thing that made the problem. It mimicked Windows 7.

not-nef commented 2 years ago

When is republic day?

26 Jan in India. Wikipedia will tell you more about the specialty. Also, I think we shouldn't use Darkdetect, that was the thing that made the problem. It mimicked Windows 7.

I could make it exclusive for windows 10 and 11

im-coder-lg commented 2 years ago

I could make it exclusive for windows 10 and 11

Try that now.