Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

perf: Fix performance #73

Closed sumeshir26 closed 2 years ago

sumeshir26 commented 2 years ago

Heavily WIP. Only Second support as of now

netlify[bot] commented 2 years ago

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: 039a928a4a92cac2528c986cbce3916a5f4326e6

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/61fa14f6418e68000829193e

not-nef commented 2 years ago

epic

not-nef commented 2 years ago

How do you want to do a millisecond timer? We cant configure the label text for every millisecond?

im-coder-lg commented 2 years ago

Maybe use an .after() loop?

im-coder-lg commented 2 years ago

Fixed a merge conflict :)

sumeshir26 commented 2 years ago

How do you want to do a millisecond timer? We cant configure the label text for every millisecond?

@not-nef The timer dosent loop every millisecond, it just checks the current time and checks it with the time at the start of the timer and subtracts it to get the time passed. Sorry if its confusing

not-nef commented 2 years ago

Not confusing at all! Makes perfect sense.

im-coder-lg commented 2 years ago

Hey, has anyone invited me on Replit? Got a mail.

im-coder-lg commented 2 years ago

Oh nvm, it's our (new) Replit team. Just us.

im-coder-lg commented 2 years ago

@TimerX-App/reviewers any updates here? Is this ready? Edit: Making the title semantic, heads up!

sumeshir26 commented 2 years ago

No it’s not near ready, it’s going to take about a week more. I’m not at home so I can’t work on TimerX this weekend.

im-coder-lg commented 2 years ago

Wow. Alright, I'll try working on something else. Regarding the update system, I frankly need some help. If you could try telling me the next steps, I'll try implementing them.

sumeshir26 commented 2 years ago

Wait, can you work on the Update system on repl.it so I can help you using repl.it multiplayer

im-coder-lg commented 2 years ago

I will start tomorrow. Today's a Sunday.

im-coder-lg commented 2 years ago

Are you making progress?

sumeshir26 commented 2 years ago

@im-coder-lg Yes, after today's commits, it is actually usable with pausing! There is just a slight visual glitch with pausing which I will fix tomorrow at the latest. That glitch is purely visual and does not affect the actual timer. Can you please test the timer on raspbian?

im-coder-lg commented 2 years ago

I'll have to test on Ubuntu, I distro-hopped. But if it works on ARM64, it will work on ARMV7L.

im-coder-lg commented 2 years ago

I wish we had users who have macOS Latest so that they could also test, I feel bad for the people left out.

sumeshir26 commented 2 years ago

Ok, tell me when you test

im-coder-lg commented 2 years ago

Hold up, there is Coder, it alows teams to develop programs easily. They have a bunch of Dockerised images, I wonder if a macOS image is also included on it. Then, I could test it, right?

sumeshir26 commented 2 years ago

Isnt coder paid?

im-coder-lg commented 2 years ago

Docker deployments, you can take it for testing!

im-coder-lg commented 2 years ago

Wait, you know Coder? Leave it, but I'll search around their registry for macOS images and try installing them. Last time I tried it, it failed horribly. Also, I don't have a subscription and I don't need one. I'll just host it on a Gitpod container and play around.

im-coder-lg commented 2 years ago

Oh turd, latency is high. Wait, I'll test after switching my network.

im-coder-lg commented 2 years ago

Also, what do you guys think of a code formatting workflow that uses cron? I think that is more than enough to format our website and our Python code.

not-nef commented 2 years ago

Dont know what that is but ok

im-coder-lg commented 2 years ago

I have started installing Coder on Gitpod, the dockerised version ofc, maybe we could test on other OSes. There are VNC images too, so we could hopefully succeed in our test.

sumeshir26 commented 2 years ago

You know coder?

Github kept reccomending code-server to me

im-coder-lg commented 2 years ago

Alright, no macOS :( but we might test on Ubuntu or CentOS(same as Fedora) Test failed :( due to the internet thing

im-coder-lg commented 2 years ago

Github kept recommending code-server to me

Wow. Did you see it? Damn, that's the place where I do half my work with other maintainers there, helping them out. Moreover, code-server and Gitpod are the same, except Gitpod gave you an OS, to begin with. Edit: Maybe I get why GitHub recommended code-server. Mostly due to my activities there. I comment on half of the discussions trying to help out and occasionally make PRs, hence GitHub might've recommended.

im-coder-lg commented 2 years ago

Dont know what that is but ok

Basically, the on: YAML block has a cronjob. It triggers on that specific second. Then, I'll create a PAT here so that the formatter won't throw errors saying that it can't edit some protected files. So, after linking an env secret, I'll commit the file and it will trigger on that moment.

im-coder-lg commented 2 years ago

Test still fails. I'll go ahead with adding a Wine setup for TimerX in the docs.

sumeshir26 commented 2 years ago

@not-nef @im-coder-lg I need some help. When the timer gets paused, the time display slightly changes. I have no idea what is causing this and the timer fixes it after unpausing. Can you please look at the code and see what needs to be changed?

im-coder-lg commented 2 years ago

Wait, let's try investigating.

  1. Did you add anything to the time display?
  2. Did you meddle with any functions the time display uses?
  3. Did you try changing the layout?

If you have a yeah for something in this, then edit that code only. If it lingers, think out of that code boundary. If it still fails, let's go to StackOverflow.

not-nef commented 2 years ago

@not-nef @im-coder-lg I need some help. When the timer gets paused, the time display slightly changes. I have no idea what is causing this and the timer fixes it after unpausing. Can you please look at the code and see what needs to be changed?

Wdym it changes?

sumeshir26 commented 2 years ago

I think I figured out the solution, will commit it tommorow so we can get this merged by thursday

not-nef commented 2 years ago

Cool! Next week i will add the ui to the missing settings and then we are technically ready for 1.1!

im-coder-lg commented 2 years ago

When shall we release it?

not-nef commented 2 years ago

What about the 16th?

im-coder-lg commented 2 years ago

Hmm... @sumeshir26 any ideas?

sumeshir26 commented 2 years ago

Sure

sumeshir26 commented 2 years ago

@im-coder-lg Need your review on this!

im-coder-lg commented 2 years ago

I need to test this now.

sumeshir26 commented 2 years ago

Will format it tomorrow when I get to my pc.