Add Fullscreen setting

[not-nef]

im back woohoo Closes #69

[im-coder-lg]

Whoa bro this seems great. Waiting for some spare time to test this on my PC, I'm booked (not free as I was) for the coming days.

[not-nef]

lmao this took me like 20 minutes when did coding become so easy lmao

[not-nef]

btw i created a repo for calcx @im-coder-lg

[im-coder-lg]

lmao this took me like 20 minutes when did coding become so easy lmao

And people say coding and developing apps are really hard LOL.

[not-nef]

And people say coding and developing apps are really hard LOL.

Well not in python lmao

[sumeshir26]

@not-nef What are these imports for? I also think VSCode's auto-import feature is annoying if that is the cause

[sumeshir26]

Also, you didn't add the new setting to the upgrade path. I will do that

[sumeshir26]

Hmm... This is not exactly what I had in mind. My vision was this:

• The Fullscreen icon in the bottom right corner where the old AOT button was
• When clicked, the app becomes fullscreen
• The Fullscreen Button stays in the bottom right corner in fullscreen mode to exit fullscreen
• Like YouTube fullscreen

@im-coder-lg @not-nef What do you think? If you think that nef's implementation is good, we'll keep it. I just think a YouTube-like fullsecreen would be better. Feedback?

[im-coder-lg]

I still have to test this. My PC is not with me atm 😭 but I might be able to test this after I eat my lunch. No promises though. @sumeshir26 can you share a video of how it's working so that I can know what to expect?

[not-nef]

@not-nef What are these imports for?

I also think VSCode's auto-import feature is annoying if that is the cause

Yes it was.

[not-nef]

Hmm... This is not exactly what I had in mind. My vision was this:

• The Fullscreen icon in the bottom right corner where the old AOT button was

• When clicked, the app becomes fullscreen

• The Fullscreen Button stays in the bottom right corner in fullscreen mode to exit fullscreen

• Like YouTube fullscreen

@im-coder-lg @not-nef What do you think? If you think that nef's implementation is good, we'll keep it. I just think a YouTube-like fullsecreen would be better. Feedback?

I thought that setting wasn't important enough to be on the home screen.

[im-coder-lg]

I recommend @sumeshir26's idea since that would help people who use external displays. I atleast would use it when I get the chance of using external displays.

[not-nef]

Okay, will do when i get home.

[im-coder-lg]

From now, if a branch is made here, use the username/branchname format since that'd clarify who made the branch if the PR isn't made. Renaming this to not-nef/Fullscreen.

[im-coder-lg]

Oh turd that'll close the PR. Let's follow that schema from now on.

[im-coder-lg]

Line 219 got an error on my PC.

[not-nef]

What error?

[not-nef]

Ah you have to delete your old config.json and if that doesn't work, check if you updated utils.py

[im-coder-lg]

Works

[sumeshir26]

@im-coder-lg with my latest changes, it should work without issues since I added a upgrade path.

[sumeshir26]

Ohh I found out the issue, will fix it tomorrow when I get to my PC

[not-nef]

Ohh I found out the issue, will fix it tomorrow when I get to my PC

What issue? He said it works!

[sumeshir26]

It will work if you are upgrading from 1.0 to 1.1 but wont upgrade if you upgrade from the previous commit

[not-nef]

We have a biig problem. When exiting fullscreen, we cant click any buttons in the menu bar. (Atleast if we do it the way @sumeshir26 wants.) If we do it my way, the app requires a restart, and this problem doesnt occur. Its your choice @sumeshir26. Either drop this feature or we do it my way.

[sumeshir26]

@not-nef I made a branch sumeshir26/fullscreen which has what I am actuallay what i'm talking about. But for some reason it does not work. Chan you look at my code?

[sumeshir26]

@not-nef Fixed, making a PR