search

Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

feat: Fullscreen Mode #86

Closed sumeshir26 closed 2 years ago

sumeshir26 commented 2 years ago

Better implimentation of @not-nef's fullscreen

netlify[bot] commented 2 years ago

✔️ Deploy Preview for timerx-app canceled.

🔨 Explore the source changes: 5ef1892787ea42a68f25a494a2e3b4c3925310ae

🔍 Inspect the deploy log: https://app.netlify.com/sites/timerx-app/deploys/62060052ef4ac70007731d62

im-coder-lg commented 2 years ago

Screenshot please?

not-nef commented 2 years ago

@sumeshir26 can you please check if you can click the buttons in the titlebar after switching to fullscreen and back? (minimize, close, etc.)

sumeshir26 commented 2 years ago

Yes

not-nef commented 2 years ago

Ok, will also test when i get home and then hopefully approve

not-nef commented 2 years ago

Weird, the video doesn’t upload. Just believe me that it doesnt work.

not-nef commented 2 years ago

@sumeshir26 Did you find out the issue?

sumeshir26 commented 2 years ago

You can always close the app Crome the taskbar…

sumeshir26 commented 2 years ago

So it think it’s fine. Opinions?

im-coder-lg commented 2 years ago

I think it might be fine, I'll test this evening.

not-nef commented 2 years ago

You can always close the app Crome the taskbar…

After switching to fullscreen, and back, i cant anymore.

not-nef commented 2 years ago

fix or drop this feature pls i want to continue development

sumeshir26 commented 2 years ago

Well, we'll drop this then. But i will take out the maxsize. I treid that locallay and it works pretty well. Also, did you see that the ttk theme is now on PyPi? Ill take care of upgrading TimerX

not-nef commented 2 years ago

Ok

im-coder-lg commented 2 years ago

Also, did you see that the ttk theme is now on PyPi?

Really? Does it work with a PyPI import?

sumeshir26 commented 2 years ago

Yeah