Futura-Py / TimerX

A fluent Timer App, made completely in Python
https://timerx-app.netlify.app
MIT License
37 stars 5 forks source link

More Settings #90

Closed not-nef closed 2 years ago

not-nef commented 2 years ago

It kinda works, but playsound gives me an error i dont know how to fix pls help

Closes #50

not-nef commented 2 years ago

This took me 2 Hours

sumeshir26 commented 2 years ago

@not-nef Can there be a browse button for the sound?

sumeshir26 commented 2 years ago

This took me 2 Hours

Thanks for making this PR, man

sumeshir26 commented 2 years ago

The sound plays perfectley without errors for me

not-nef commented 2 years ago

The sound plays perfectley without errors for me

I mean if you select a custom sound

not-nef commented 2 years ago

@not-nef Can there be a browse button for the sound?

Will implement it when i get home from school today.

sumeshir26 commented 2 years ago

If i press copy-path of the sound in Files UWP, and paste it, it works perfectley

not-nef commented 2 years ago

Well then i have to look into it why it doesnt ... ohhh now i know why it didnt work.

not-nef commented 2 years ago

@sumeshir26 I found the Bug!! The error i get resides in playsound itself. Downgrading to version 1.2.2 solves it. So in the future, we just force contributers to install playsound 1.2.2 . Will commit shortly.

not-nef commented 2 years ago

Everything works, ready for merge!!

not-nef commented 2 years ago

Aw man. Merge conflicts. Will fix when im home

im-coder-lg commented 2 years ago

I'll just do it.

im-coder-lg commented 2 years ago

@not-nef I fixed it, running a styling commit to remove dupe code.

im-coder-lg commented 2 years ago

What I hate: errors of tarnations. Check for yourself. https://github.com/Futura-Py/TimerX/runs/5247954206?check_suite_focus=true#step:5:35

im-coder-lg commented 2 years ago

Have you tried rebasing the new merges here?

not-nef commented 2 years ago

Have you tried rebasing the new merges here?

What is that

not-nef commented 2 years ago

The windows build fails @im-coder-lg i will add rdbendes changes later. Just dont change anything alright?

not-nef commented 2 years ago

I also disabled blurring for light mode until we find a solution for the overexposure problem

not-nef commented 2 years ago

Finally this pr is 100% ready for merging

not-nef commented 2 years ago

LGTM

rdbende commented 2 years ago

Lol. image

not-nef commented 2 years ago

Lol. image

Whoop

not-nef commented 2 years ago

@rdbende i limited hours to 24

not-nef commented 2 years ago

@rdbende fixed

im-coder-lg commented 2 years ago

Have you tried rebasing the new merges here?

What is that

Rebasing is a method to get the latest changes on your other branches. You use Git CLI to do this, it gets the changes, adds them to git staging and once you commit it, your branch is updated! It's kinda like GitHub's UI to get the latest changes. I recommend the CLI method though.

im-coder-lg commented 2 years ago

Also, this is unrelated; does anyone have a good idea for a PC with 8 gigs of DDR4 RAM, 512 gigs of NVME SSD storage and any Linux distro with godly customization(not Arch Linux)? I need one or at least, does KDE work on a Dell that's kinda 5-8 years old?

not-nef commented 2 years ago

Also, this is unrelated; does anyone have a good idea for a PC with 8 gigs of DDR4 RAM, 512 gigs of NVME SSD storage and any Linux distro with godly customization(not Arch Linux)? I need one or at least, does KDE work on a Dell that's kinda 5-8 years old?

My pc has 12 gb ram and 512 GB SSD

im-coder-lg commented 2 years ago

Right, great! I will be busy till April. From fests to exams to fests and bridging to the next academic year. But I think I'll have some time for doing while working on great geometric projects. If you want to see them, please don't if you are photosensitive though.

im-coder-lg commented 2 years ago

My pc has 12 gb ram and 512 GB SSD

I think I'll use my old Dell for now. But I need good or great distros to use. Is Kubuntu nice? I tried a VM during 2018, but never passed the installing stage. Moreover, Windows 11 is just overkill for this.

not-nef commented 2 years ago

I think I'll use my old Dell for now. But I need good or great distros to use. Is Kubuntu nice? I tried a VM during 2018, but never passed the installing stage. Moreover, Windows 11 is just overkill for this.

Idk anything about linux

not-nef commented 2 years ago

@im-coder-lg Can you approve?

im-coder-lg commented 2 years ago

Will try today!

sumeshir26 commented 2 years ago

I reccomend Manjaro with KDE Plasma. I cant review soon, will review before thursday.

sumeshir26 commented 2 years ago

I would love to see your geometric projects

not-nef commented 2 years ago

I reccomend Manjaro with KDE Plasma. I cant review soon, will review before thursday.

Is it ok if we just merge?

not-nef commented 2 years ago

I mean i have tested it and it works on windows

im-coder-lg commented 2 years ago

I reccomend Manjaro with KDE Plasma. I cant review soon, will review before thursday.

But it kinda seems ugly with Manjaro's big square icon. Kubuntu seems a viable option.

I would love to see your geometric projects

Thanks 😀 I'll try putting some of them in a repo here. But it will have a GeoGebra file as well as a video and screenshot. Trust me, they will be confusing since your brain will index everything drawn there. With overlapping orders, you get confused and just blink. Then it begins again, so be careful with which geometric image you choose! PS: all of them use circles with fixed radii as base.

im-coder-lg commented 2 years ago

I mean i have tested it and it works on windows

I'll test it now!

not-nef commented 2 years ago

@im-coder-lg Did it work?

sumeshir26 commented 2 years ago

Ok, merge this

not-nef commented 2 years ago

Finally

not-nef commented 2 years ago

@sumeshir26 How do you like it? ☺️ I even added the browse button you requested

sumeshir26 commented 2 years ago

It’s awsome