Futura-Py / weather

Coming soon
MIT License
5 stars 1 forks source link

feat(ui): updates + dynamically sized window #16

Closed Moosems closed 11 months ago

Moosems commented 11 months ago

Need to still utilize the progressbar, update docs, and clean code more but this is a good start. Please: DO NOT TOUCH. @im-coder-lg, please comment that you've read this.

Closes #15

Moosems commented 11 months ago

Again, NO TOUCHY!

Moosems commented 11 months ago

I would love it if eventually we used a web-scraper rather than using an API to make it scalable and free forever.

Moosems commented 11 months ago

Artifact build is not working for me but local source running is successful.

im-coder-lg commented 11 months ago

@Moosems I saw this, and as you said, I no touchy.

I would love it if eventually we used a web-scraper rather than using an API to make it scalable and free forever.

How about migrating to PyOWM? It seems to use the API but also format the data too, so we could perhaps migrate to that.

I'll keep my eye on this, and if you need any help, just ask.

im-coder-lg commented 11 months ago

Artifact build is not working for me but local source running is successful.

I'll test it on my computer as well as my cloud Gitpod instance.

@Moosems about the dynamic scaling, are you going to try to update the values after a search for the city is done? I did that on the dynamic-scaling branch, and it works well. I think this is the way most could go, but if you have another idea, can you delete the branch? We don't have a use for it anymore.

I'm updating the title, description and adding this to the repo project for tracking progress. Just slight changes.

not-nef commented 11 months ago

hello

sumeshir26 commented 11 months ago

hello

hi, good to see you back

not-nef commented 11 months ago

i kinda lost motivation for programming after that one bug in notes that i couldn’t fix

sumeshir26 commented 11 months ago

i kinda lost motivation for programming after that one bug in notes that i couldn’t fix

tkinter is frustrating sometimes. ive kinda moved on from tkinter programming at this point, and am learning newer things, so even i dont contribute much these days.

not-nef commented 11 months ago

i just think that tkinters simplicity is nice so i am kinda hanging onto it

Moosems commented 11 months ago

Will make settings UI.

Moosems commented 11 months ago

Need to set up a simple file system, saving to it, and update the label info based on the systems.

im-coder-lg commented 11 months ago

@Moosems I added sv_ttk to requirements file since it was missing, now you can use build artifacts directly I think.

im-coder-lg commented 11 months ago

Wait, I know there is an error with the artifact, I know the fix. 1 min!

im-coder-lg commented 11 months ago

I reverted my changes. @Moosems the artefacts don't recognise sv_ttk even after my changes. Can you look into it?

im-coder-lg commented 11 months ago

Also, can you change the City label text's variables to the one I suggested? At least the name would be enough, so it auto-corrects the city name after receiving it.

Moosems commented 11 months ago

Also, can you change the City label text's variables to the one I suggested? At least the name would be enough, so it auto-corrects the city name after receiving it.

What?

Moosems commented 11 months ago

@im-coder-lg Wait to touch the PR until I'm done please, still making some large changes ;).

Moosems commented 11 months ago

I'll get the artifacts fixed, don’t worry.

Moosems commented 11 months ago

Mac builds run fine from artifacts but now Linux is acting up.

im-coder-lg commented 11 months ago

Also, can you change the City label text's variables to the one I suggested? At least the name would be enough, so it auto-corrects the city name after receiving it.

What?

        cityname = data["name"] + ", " + data["sys"]["country"]
        # Set the city name
        self.cityname.configure(text=f"City: {cityname}")

This. If you add this to main.py, the proper city name will be taken from the API.

@im-coder-lg Wait to touch the PR until I'm done please, still making some large changes ;).

Okay, but do it fast! Linux builds don't work due to the addition of Sun Valley.

I'll get the artifacts fixed, don’t worry.

Okay, but make sure the .spec files are proper.

Mac builds run fine from artifacts but now Linux is acting up.

Have you checked the .spec files? Maybe we must add sv_ttk as a hidden import(though it didn't work, but worth a try).

Moosems commented 11 months ago

You are clear to work on the Linux builds. Try to keep changes minimal if possible.

Moosems commented 11 months ago

Okay, but make sure the .spec files are proper.

I only added hooks. Would you open a discussion asking for thoughts on the PyInstaller repo?

im-coder-lg commented 11 months ago

Okay, but can't do today :( got too much of backlog to finish here. I still don't know how it accumulates. 🤔

Of course, I'll check with PyInstaller devs on this behaviour. I might have to mention this PR there, but we'll see. Add your changes and let's wait and watch.

Moosems commented 11 months ago

I'd give them the hook file, spec file, and then the traceback and leave it there, no need to link a big PR.

im-coder-lg commented 11 months ago

Posted a discussion over at PyInstaller: https://github.com/orgs/pyinstaller/discussions/7869

I linked the repo and the files, and only that, so this PR isn't linked but is accessible. I hope I get an answer to the issue soon.

Moosems commented 11 months ago

There was a response. @im-coder-lg could you have the Linux build use a newer Python version?

Moosems commented 11 months ago

3.9 or sooner.

Moosems commented 11 months ago

Or maybe a from __future__ import annotations would fix that.

im-coder-lg commented 11 months ago

We would have to rebase from main. I'll manage that mess, if you want me to. The workflow can be updated only on the main branch, so we gotta rebase, no questions asked.

im-coder-lg commented 11 months ago

Oh, fixed it with GitHub's UI. I thought we had to use Git :/

im-coder-lg commented 11 months ago

https://github.com/Futura-Py/weather/assets/76845820/7b7d26fe-85f0-417b-818c-ccbba335f1b3

IT WORKS!!!!!

yeah!

Finally, I pulled the recording off. Not so fancy as before, Clipchamp straight up reloaded to the login site over and over again.

Moosems commented 11 months ago

Ready to merge?