Futura-Py / weather

Coming soon
MIT License
5 stars 1 forks source link

Update system #19

Closed not-nef closed 9 months ago

not-nef commented 10 months ago

this is the thing. im not quite sure if you guys want it to check on restart or have a button on the about page. please let me know thanks!

im-coder-lg commented 10 months ago

Gotta add Sun Valley theming soon... Is it on your checklist? @Moosems I need you to start on the Settings Tab interface and @sumeshir26 if you are done with the About page code, we can add it onto the PR. I'll try finding anything else we can add, and would do so myself, with prior announcement/warning/anything else. @not-nef you do use a VERSION variable here, right? Edit: oh nvm, you do. I'll try scanning the code properly :)

Moosems commented 10 months ago

It already uses sun valley theming...

not-nef commented 10 months ago

doesnt the app already have the sv theme?

im-coder-lg commented 10 months ago

The update window doesn't and there is no helpful answer on this. Seems like when using Tcl/Tk 8.6 it works, but not with Python. 🤷

im-coder-lg commented 10 months ago

We gotta add it soon.

im-coder-lg commented 10 months ago

keyboard glitched

im-coder-lg commented 10 months ago

I held shift key and the keybinding ctrl + shift + enter closes the PR with a comment.

Moosems commented 10 months ago

The update window doesn't and there is no helpful answer on this. Seems like when using Tcl/Tk 8.6 it works, but not with Python. 🤷

Message boxes don't get themes...

not-nef commented 10 months ago

i might make a messagebox class with sv theming like rdbende did

sumeshir26 commented 10 months ago

Gotta add Sun Valley theming soon... Is it on your checklist? @Moosems I need you to start on the Settings Tab interface and @sumeshir26 if you are done with the About page code, we can add it onto the PR. I'll try finding anything else we can add, and would do so myself, with prior announcement/warning/anything else. @not-nef you do use a VERSION variable here, right? Edit: oh nvm, you do. I'll try scanning the code properly :)

I am waiting for this PR to be merged so that I can add it based on the final design of the Update system.

Moosems commented 10 months ago

I'm choosing to wait to add my updates until y'all are sure you're done making changes.

not-nef commented 10 months ago

my pc is currently not booting so i cant finish this pr 😭

im-coder-lg commented 10 months ago

Have you tried booting into Windows via boot list? Not saying BIOS/UEFI, but the OS list, which can be accessed by hitting F2 or F12 depending on the manufacturer. You can then add your changes and merge the PR.

not-nef commented 10 months ago

it wont even get into the bios, i think my motherboard is broken, i am gonna call the support hotline today

Moosems commented 10 months ago

We're you messing with it recently?

not-nef commented 10 months ago

not at all i did nothing, i am currently digging up my linux pc to set it up for development

not-nef commented 10 months ago

great my linux pc works, i will finish this pr asap

im-coder-lg commented 10 months ago

Gotta check this on my PC soon. But anyway, if it works on your development machine, it sure as hell works on mine. Still approved, no changes.

im-coder-lg commented 10 months ago

@Futura-Py/reviewers what is the status of this PR? We gotta close this soon, got more features coming for this app. We gotta start working on TimerX too, brush the code up, add some extras and polish it up.

not-nef commented 10 months ago

i volunteer for a timerx rewrite, but i am still busy with notes and the super secret org website that youre all supposed to know nothing about

sumeshir26 commented 10 months ago

i volunteer for a timerx rewrite, but i am still busy with notes and the super secret org website that youre all supposed to know nothing about

This time around, should we give a try to build in Stopwatch, Timer, and World Clock modes? I will also try to work on TimerX. And the Org website sounds interesting!

im-coder-lg commented 10 months ago

I want to make the website myself, but I'm too busy to even code. Can we do the website next year, around May? I can help out with that freely then.

sumeshir26 commented 10 months ago

I want to make the website myself, but I'm too busy to even code. Can we do the website next year, around May? I can help out with that freely then.

Maybe @not-nef can get the website working now, and you can make your changes after our boards...

im-coder-lg commented 10 months ago

Yeah. I hope I get the first rank in my school. Maybe then I can get some accessories as well as a small RAM upgrade to my computer.

not-nef commented 10 months ago

I want to make the website myself, but I'm too busy to even code. Can we do the website next year, around May? I can help out with that freely then.

I have already made some good progress with it and also i am not quite sure if we have the same vision for it.

not-nef commented 10 months ago

i will upload the code once it is semi-useable

Moosems commented 10 months ago

I don't see the need for ttk popups. The defaults are system ones and look fine by default. The app does not need this much code for something so small.

not-nef commented 10 months ago

the system ones look old, perhaps if i refactor the code i can make it smaller, give me some time

not-nef commented 10 months ago

we can also use them for an about window

not-nef commented 10 months ago

i really dont want to decide this alone @sumeshir26 @im-coder-lg what so you think? keep sv messageboxes or get rid of them

sumeshir26 commented 10 months ago

i really dont want to decide this alone @sumeshir26 @im-coder-lg what so you think? keep sv messageboxes or get rid of them

Imo we should keep them. They fit the app nicely, and dont even add that much of a overhead.

BTW the website looks nice.

Moosems commented 10 months ago

Make it into classes and I'll approve. The extra types of messageboxes can be removed until we actually need them.

not-nef commented 10 months ago

the new school year started today. i will need to do some stuff and then ill get right to it

not-nef commented 10 months ago

@Moosems done

im-coder-lg commented 10 months ago

the new school year started today. i will need to do some stuff and then ill get right to it

And mine started long back. I will do so much more for Weather after the boards here. I know I can ace it, just need to prepare for it.

not-nef commented 9 months ago

@Moosems is this ready for merging? and also do you guys want to add the icon i made?

im-coder-lg commented 9 months ago

I think we can merge it, let's wait for @Moosems. And I like the icon, we can use it.

im-coder-lg commented 9 months ago

There will be almost certain mutiny if I say no so I reluctantly approve.

Why? The PR has been open for a long time, of course, but any final updates can be added quickly. Of course, if @not-nef agrees. But you approved, so I'm merging this PR.

im-coder-lg commented 9 months ago

Updating branch...

im-coder-lg commented 9 months ago

Hell, I'm merging this now.