Closed not-nef closed 9 months ago
Gotta add Sun Valley theming soon... Is it on your checklist?
@Moosems I need you to start on the Settings Tab interface and @sumeshir26 if you are done with the About page code, we can add it onto the PR. I'll try finding anything else we can add, and would do so myself, with prior announcement/warning/anything else. @not-nef you do use a VERSION
variable here, right?
Edit: oh nvm, you do. I'll try scanning the code properly :)
It already uses sun valley theming...
doesnt the app already have the sv theme?
The update window doesn't and there is no helpful answer on this. Seems like when using Tcl/Tk 8.6 it works, but not with Python. 🤷
We gotta add it soon.
keyboard glitched
I held shift key and the keybinding ctrl
+ shift
+ enter
closes the PR with a comment.
The update window doesn't and there is no helpful answer on this. Seems like when using Tcl/Tk 8.6 it works, but not with Python. 🤷
Message boxes don't get themes...
i might make a messagebox class with sv theming like rdbende did
Gotta add Sun Valley theming soon... Is it on your checklist? @Moosems I need you to start on the Settings Tab interface and @sumeshir26 if you are done with the About page code, we can add it onto the PR. I'll try finding anything else we can add, and would do so myself, with prior announcement/warning/anything else. @not-nef you do use a
VERSION
variable here, right? Edit: oh nvm, you do. I'll try scanning the code properly :)
I am waiting for this PR to be merged so that I can add it based on the final design of the Update system.
I'm choosing to wait to add my updates until y'all are sure you're done making changes.
my pc is currently not booting so i cant finish this pr ðŸ˜
Have you tried booting into Windows via boot list? Not saying BIOS/UEFI, but the OS list, which can be accessed by hitting F2 or F12 depending on the manufacturer. You can then add your changes and merge the PR.
it wont even get into the bios, i think my motherboard is broken, i am gonna call the support hotline today
We're you messing with it recently?
not at all i did nothing, i am currently digging up my linux pc to set it up for development
great my linux pc works, i will finish this pr asap
Gotta check this on my PC soon. But anyway, if it works on your development machine, it sure as hell works on mine. Still approved, no changes.
@Futura-Py/reviewers what is the status of this PR? We gotta close this soon, got more features coming for this app. We gotta start working on TimerX too, brush the code up, add some extras and polish it up.
i volunteer for a timerx rewrite, but i am still busy with notes and the super secret org website that youre all supposed to know nothing about
i volunteer for a timerx rewrite, but i am still busy with notes and the super secret org website that youre all supposed to know nothing about
This time around, should we give a try to build in Stopwatch, Timer, and World Clock modes? I will also try to work on TimerX. And the Org website sounds interesting!
I want to make the website myself, but I'm too busy to even code. Can we do the website next year, around May? I can help out with that freely then.
I want to make the website myself, but I'm too busy to even code. Can we do the website next year, around May? I can help out with that freely then.
Maybe @not-nef can get the website working now, and you can make your changes after our boards...
Yeah. I hope I get the first rank in my school. Maybe then I can get some accessories as well as a small RAM upgrade to my computer.
I want to make the website myself, but I'm too busy to even code. Can we do the website next year, around May? I can help out with that freely then.
I have already made some good progress with it and also i am not quite sure if we have the same vision for it.
i will upload the code once it is semi-useable
I don't see the need for ttk popups. The defaults are system ones and look fine by default. The app does not need this much code for something so small.
the system ones look old, perhaps if i refactor the code i can make it smaller, give me some time
we can also use them for an about window
i really dont want to decide this alone @sumeshir26 @im-coder-lg what so you think? keep sv messageboxes or get rid of them
i really dont want to decide this alone @sumeshir26 @im-coder-lg what so you think? keep sv messageboxes or get rid of them
Imo we should keep them. They fit the app nicely, and dont even add that much of a overhead.
BTW the website looks nice.
Make it into classes and I'll approve. The extra types of messageboxes can be removed until we actually need them.
the new school year started today. i will need to do some stuff and then ill get right to it
@Moosems done
the new school year started today. i will need to do some stuff and then ill get right to it
And mine started long back. I will do so much more for Weather after the boards here. I know I can ace it, just need to prepare for it.
@Moosems is this ready for merging? and also do you guys want to add the icon i made?
I think we can merge it, let's wait for @Moosems. And I like the icon, we can use it.
There will be almost certain mutiny if I say no so I reluctantly approve.
Why? The PR has been open for a long time, of course, but any final updates can be added quickly. Of course, if @not-nef agrees. But you approved, so I'm merging this PR.
Updating branch...
Hell, I'm merging this now.
this is the thing. im not quite sure if you guys want it to check on restart or have a button on the about page. please let me know thanks!