Controlling for `pymupdf` version in `test_pdf_reader_match_doc_details` VCR - Githubissues

Future-House / paper-qa

High accuracy RAG for answering questions from scientific documents with citations

Apache License 2.0

6.44k stars 618 forks source link

Controlling for `pymupdf` version in `test_pdf_reader_match_doc_details` VCR #538

Closed jamesbraza closed 1 month ago

jamesbraza commented 1 month ago

As we see in this CI run, test_pdf_reader_match_doc_details has failed again. But it has a VCR, so why was it failing?

I traced it to going from pymupdf==1.24.10 to pymupdf==1.24.11 invalidating the VCR. So we can fix this now-failing test in one of two ways:

Pinning pymupdf in dev dependencies
Adding pymupdf to VCR key for this test

In this PR, I did the folowing:

Adjusted the test_pdf_reader_match_doc_details's VCR name to include pymupdf.__version__ in the name
Removed less specific match_on configuration from our conftest, and regenerated all VCR cassettes