FutureHax / OpenHueSdk

Android compatible HUE SDK
Apache License 2.0
4 stars 4 forks source link

Changes to Whitelist username creation #1

Open SteveyO opened 8 years ago

SteveyO commented 8 years ago

Hi there,

I work for Philips Hue Developer Support. In case you are not aware we are changing the way we authenticate against the bridge in a few months time. Basically, custom whitelist entries will no longer be allowed. See below links for more info. http://www.developers.meethue.com/documentation/important-whitelist-changes http://www.developers.meethue.com/documentation/getting-started

I had a quick look at your code and it looks like you are passing in both the devicetype and username (in the RegistrationRequest object in BridgeRegistrar.java, lines 105, 108). For future bridge versions, the username should be removed and the randomly generated bridge usernames will be returned in the Bridge response (again, see above links).

I see you have not committed for over a year so not sure if this project is still active. If it is you may want to change this at some point so it remains compliant with future bridge versions.

Let me know if any doubts.

Thanks Steve

r2DoesInc commented 8 years ago

The project still works, but there just hasnt been any movement recently that has necessitated and updates to this implementation. Thank you for the heads up, I will be sure to bring this up to date.

On Mon, Nov 2, 2015 at 11:06 AM, Steve notifications@github.com wrote:

Hi there,

I work for Philips Hue Developer Support. In case you are not aware we are changing the way we authenticate against the bridge in a few months time. Basically, custom whitelist entries will no longer be allowed. See below links for more info. http://www.developers.meethue.com/documentation/important-whitelist-changes http://www.developers.meethue.com/documentation/getting-started

I had a quick look at your code and it looks like you are passing in both the devicetype and username (in the RegistrationRequest object in BridgeRegistrar.java, lines 105, 108). For future bridge versions, the username should be removed and the randomly generated bridge usernames will be returned in the Bridge response (again, see above links).

I see you have not committed for over a year so not sure if this project is still active. If it is you may want to change this at some point so it remains compliant with future bridge versions.

Let me know if any doubts.

Thanks Steve

— Reply to this email directly or view it on GitHub https://github.com/FutureHax/OpenHueSdk/issues/1.

SteveyO commented 8 years ago

Great! Thanks for your fast reply. Just after I posted the above I also noticed you have 2 Hue apps in the Google Play Store. I haven't got round to testing these yet (will do so tomorrow), but also please make sure they use the randomly generated bridge usernames the next time you update them (if not already). If you could let me know when this is done it would be appreciated, and apologies for the inconvenience. Obviously this is a bit of a pain for developers of existing Hue apps, but the change is needed for improving the security of the Hue system. I will post the exact date (when the change will be made public) in the news section of www.developers.meethue.com as soon as it is known. Thanks Steve