FutureMillennium / Screenshot-YouTube

Chrome extension: Take a screenshot of any YouTube video with one click.
https://chrome.google.com/webstore/detail/screenshot-youtube/gjoijpfmdhbjkkgnmahganhoinjjpohk
130 stars 29 forks source link

Extension requires permission to read browsing history #34

Open danieljbk opened 4 months ago

danieljbk commented 4 months ago

screenshot

This is a screenshot of permissions stated as required when installing extension from Chrome store.

Why does it state the extension can view the user's browsing history? Such a permission doesn't seem to be in the code.

And, I don't initially see a reason this extension would need to read the user's browsing history.

So...

  1. Either this is a bug,
  2. I didn't find where that permission is located in the code, or
  3. The code in this repo is different from the code of the actual extension.
danieljbk commented 4 months ago

CleanShot 2024-05-17 at 11 37 19@2x

Manually installing the extension with this repo also required this permission. So the answer was number 2 - I didn't locate that permission in the code.

However, the question remains why this permission is required. It shouldn't be, intuitively.

I will assume it is a bug and leave this issue open, but I'm aware that it may be a workaround or something of that sort.

FutureMillennium commented 4 months ago

It watches history on youtube.com to add the Screenshot button and others, because Youtube rewrites history instead of doing a page load/reload when you i.e. click on a video. https://github.com/FutureMillennium/Screenshot-YouTube/blob/master/extension/background.js There's probably a better solution…