search

FuturePathAI / Learn-AI-Engineering

Code, notebooks, and other material for FuturePath AI's training course on Generative AI
MIT License
8 stars 6 forks source link

🔥 Merge Notebooks 17 and 19 #36

Closed RheagalFire closed 6 months ago

RheagalFire commented 6 months ago

Description

merge Notebooks 17 and 19

Issue

Closes #34

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

NirantK commented 6 months ago

This does not look like a merge but a plain deletion of one notebook? I don't see a section on special tokens in the updated and modified notebook

NirantK commented 6 months ago

And it needs to have the MLM task (BERT notebook?) covered in the same notebook as tokenizer, while the NWP prediction can go with special tokens since that ties into chat/instruction formatting.

NirantK commented 6 months ago

So this gets merged into 1 notebook:

  1. Tokens and Tokenizer
  2. MLM and BERT
  3. Next Word Prediction
  4. Special Tokens and Instruction/Chat Format
RheagalFire commented 6 months ago

This does not look like a merge but a plain deletion of one notebook? I don't see a section on special tokens in the updated and modified notebook

The exact same section was already present in the notebook which is renamed.

RheagalFire commented 6 months ago

So this gets merged into 1 notebook:

  1. Tokens and Tokenizer
  2. MLM and BERT
  3. Next Word Prediction
  4. Special Tokens and Instruction/Chat Format

Done , can you check and LMK if everything looks good.