Issue signed integers on mysql glpi-webhook branch 2.0.0 for Glpi 10 on 10.0.2 version

FutureProcessing / glpi-webhook

GNU Affero General Public License v3.0

7 stars 4 forks source link

Issue signed integers on mysql glpi-webhook branch 2.0.0 for Glpi 10 on 10.0.2 version #9

Closed baptbapt closed 1 year ago

baptbapt commented 2 years ago

Hi, i 've try glpi-webhook branch 2.0.0 for Glpi 10 on 10.0.2 version with a mysql db.

glpiphplog.WARNING:   *** PHP User Warning (512): Usage of signed integers in primary or foreign keys is discouraged, please use unsigned integers instead in `glpi_plugin_fpwebhook_subscriptions`.`filtering_category_id`. in /var/www/glpi/src/DBmysql.php at line 2025
  Backtrace :
  src/DBmysql.php:2025                               trigger_error()
  src/DBmysql.php:361                                DBmysql->checkForDeprecatedTableOptions()
  src/DBmysql.php:1002                               DBmysql->query()
  plugins/fpwebhook/inc/installer.class.php:124      DBmysql->runFile()
  plugins/fpwebhook/hook.php:79                      PluginFpwebhookInstaller->applySchema()
  src/Plugin.php:779                                 plugin_fpwebhook_install()
  :                                                  Plugin->install()
  src/Marketplace/Controller.php:545                 call_user_func()
  src/Marketplace/Controller.php:435                 Glpi\Marketplace\Controller->setPluginState()
  ajax/marketplace.php:82                            Glpi\Marketplace\Controller->installPlugin()

there is anyone on same issue ? Regards.

daaraxd commented 2 years ago

+1 here

mikron-ia commented 1 year ago

This warning comes from the fact that the field filtering_category_id had indeed the unsigned INT(11) as type in 1.1.0; it was switched to the more appropriate BIGINT UNSIGNED in 2.0.0. This may appear:

if you run 1.1.0 on GLPI 10 before upgrading the plugin to 2.0.0 (might be the case here)
if you run GLPI 9.x with the 1.1.0 version (not the case here)

and should disappear once you upgrade the plugin to 2.0.0 or above.

Since I am unable to reproduce the problem on my installation, I must ask you to re-verify if the issue still exists once you upgraded to the released 2.0.0 on the current GLPI version.

mikron-ia commented 1 year ago

Since this:

disappears in 2.0.0
does not break anything
there was no answer to the explanation/check above

I'm closing this one as done/wontfix