FutureSharks / rpi-security

A security system written in python to run on a Raspberry Pi with motion detection and mobile notifications
GNU General Public License v2.0
215 stars 71 forks source link

kamene != scapy #48

Closed gpotter2 closed 4 years ago

gpotter2 commented 4 years ago

Hi,

I'm a Scapy maintainer, and have bumped into this project because it was linked in https://github.com/phaethon/kamene/network/dependents

I've noticed that you were using kamene. I'm assuming you were using scapy-python3 before it was renamed. Please note that kamene is NOT an official Scapy version. Quoting https://scapy.net/

An independent fork of Scapy was created from v2.2.0 in 2015, aimed at supporting only Python3 (scapy3k). The fork diverged, did not follow evolutions and fixes, and has had its own life without contributions back to Scapy. Unfortunately, it has been packaged as python3-scapy in some distributions, and as scapy-python3 on PyPI leading to confusion amongst users. It should not be the case anymore soon. Scapy supports Python3 in addition to Python2 since 2.4.0. Scapy v2.4.0 should be favored as the official Scapy code base. The fork has been renamed as kamene.

Why this is a problem

There are two issues:

I'd advise switching to scapy = the original Scapy. Note that all you need to do is change the import name.

Thanks for your time !

PS: sorry if this feels copy/pasted. It is a bit :(

FutureSharks commented 4 years ago

OK thanks for the info @gpotter2!

I switched this project to python3 and then just figured scapy-python3 was scapy, then this was renamed, so I switched to kamene.

I'd advise switching to scapy = the original Scapy. Note that all you need to do is change the import name

OK I'll do that