FutureTense / keymaster

Home Assistant integration for managing Z-Wave enabled locks
MIT License
218 stars 44 forks source link

fix: add FE599 lock 'user access' code to `alarmType` map #282

Closed firstof9 closed 2 years ago

firstof9 commented 2 years ago

Proposed change

Adds FE599 'User Access' code to alarmType map Fix tests, remove python 3.8 from tests and adds python 3.10

Type of change

Additional information

codecov-commenter commented 2 years ago

Codecov Report

Merging #282 (473ce41) into main (efd4995) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #282   +/-   ##
=======================================
  Coverage   84.14%   84.14%           
=======================================
  Files          10       10           
  Lines         801      801           
=======================================
  Hits          674      674           
  Misses        127      127           
Impacted Files Coverage Δ
custom_components/keymaster/const.py 100.00% <ø> (ø)
firstof9 commented 2 years ago

Ignore the HACS validation failure, this will fix that as well.

fireheadman commented 2 years ago

Ready to test when you when you are

firstof9 commented 2 years ago

update to v0.0.80 and give it a whirl.

fireheadman commented 2 years ago

updated, restarted HA. tested out lock/unlocked by button and entered code. neither of these methods triggered a notification.

unsure if there is anything else I need to perform after applying the update to v0.0.80

firstof9 commented 2 years ago

Double check the notifications make sure either <doorname>_lock_notifications is on or that the notifications are on for the code slot.

Also see if the event keymaster_lock_state_changed fires when you do anything with the lock too.

fireheadman commented 2 years ago

notifications are on (per screenshot) image image image image

showing the automation last triggered image

fireheadman commented 2 years ago

Also went through the 'configure' process once more. No change... no notifications for either FE599.

firstof9 commented 2 years ago

Any keymaster_lock_state_changed events when you do anything to that lock?

fireheadman commented 2 years ago

absolutely nothing reporting in the developer --> events (zwave_js_notification)

and this is the Z-WaveJS Logs showing a code entered to unlock the door

image

firstof9 commented 2 years ago

keymaster_lock_state_changed not zwave_js_notification totally different events

firstof9 commented 2 years ago

here's an example:

{
    "event_type": "keymaster_lock_state_changed",
    "data": {
        "notification_source": "event",
        "lockname": "frontdoor",
        "entity_id": "lock.kwikset_touchpad_electronic_deadbolt_frontdoor",
        "state": "locked",
        "action_text": "Manual lock operation",
        "code_slot": 0,
        "code_slot_name": ""
    },
    "origin": "LOCAL",
    "time_fired": "2022-06-01T00:54:25.335310+00:00",
    "context": {
        "id": "01G4EC3CSQB64ENPFCYK45VHGW",
        "parent_id": null,
        "user_id": null
    }
}
fireheadman commented 2 years ago

nothing when listening to this event did a code to unlock, also pressed the lock button on the door. image

fireheadman commented 2 years ago

and for reference... I did the same for my BE649ZP lock just to see the content like you gave. image

firstof9 commented 2 years ago

Ooof these FE599s :disappointed: