Fix clear_code service schema and logic and set_code service logic

raman325 commented 3 years ago

Proposed change

I don't think the clear_code service schema made sense because the function expects to get an entity_id not a node_id. In addition, when not using ozw, the function was calling the zwave integrations clear_usercodes and set_usercode service with the entity_id instead of the node_id. This PR resolves both issues. I did a little bit of cleanup while I was there which is why this change looks bigger than it functionally is.

NOTE: I don't think this is a breaking change because I don't see how this service could have possibly worked in the past. But feel free to correct me if I am wrong and I can add the necessary comment to the PR

Type of change

[ ] Dependency upgrade
[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (which adds functionality)
[ ] Breaking change (fix/feature causing existing functionality to break)
[ ] Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:

firstof9 commented 3 years ago

I like these changes, can you stash them for now?

raman325 commented 3 years ago

I'm going to keep adding to this branch but will close this PR for now and will submit a bigger update with additional changes later

FutureTense / lock-manager