search

Fuzss / bettertridents

You didn’t know your trident could do that! A crafting recipe, better loyalty, and more!
https://www.curseforge.com/minecraft/mc-mods/better-tridents
Mozilla Public License 2.0
1 stars 8 forks source link

[Bug]: Items in the Inventorio's Utility Belt gets deleted when a trident return #11

Open DTech10 opened 1 year ago

DTech10 commented 1 year ago

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

v4.0.2

Notes (Required)

Dunno if I should report this here or in Inventorio issues i kept accidentally deleting my items

  1. throw the trident with loyalty
  2. swap utility belt slot (offhand slot) with different item
  3. the trident replaced that item and the item is deleted maybe make the trident return to the slot it was thrown from and not the offhand slot currently using if that make sense or return the trident to the inventory example https://youtu.be/k1qzFErYexg

latest.log (Optional)

No response

Eir-nya commented 1 year ago

Bumping this since I just encountered the same issue and it deleted some of my best gear. If the option to return tridents to the same slot is disabled in the config, the issue doesn't happen. I think it's just that logic that's the problem.

Fuzss commented 1 year ago

I attempted a fix to this in v8.0.1 for 1.20.1. It would be great if one of you could test if this works with Inventorio now, so that I can port the fix to 1.19.2.

DTech10 commented 1 year ago

Tested it but world kept crashing on load

Logs

Forge 1.20.1 also tested it in fabric, same thing

Fuzss commented 1 year ago

Can you share the Fabric log please?

DTech10 commented 1 year ago

aight srry for delay this is the Fabric Logs

Fuzss commented 1 year ago

Thanks, both errors are unrelated to Better Tridents. Can you try with just Inventory and Better Tridents?

DTech10 commented 1 year ago

I removed Optifine on Forge 1.20.1 and it works, i think there's some incompability with Optifine/Sodium and perhaps Rubidium(I used it in my main Instance). I tested the loyalty trident and it doesn't delete the item but it doesn't go to the right slot either Crash Log(w/ Optifine) Latest Log(w/ Optifine) Example YT vid

Fuzss commented 1 year ago

Thanks, that‘s definitely better than an item being deleted. I will probably keep it like that, or disable returning to the offhand when inventorio ist installed.

DTech10 commented 1 year ago

dont know why it took me this long, but the reason why optifine kept crashing cuz its not compatible with the forge version