Fuzss / diagonalwalls

The missing diagonal blocks are here! After all these years. Finally, you have them all.
Mozilla Public License 2.0
2 stars 1 forks source link

[Bug]: Vertical Walls Not Flush #10

Closed JLUsr closed 2 months ago

JLUsr commented 2 months ago

Mod Loader (Required)

Quilt

Minecraft Version(s) (Required)

1.20.1

Mod Version(s) (Required)

v8.1.3

Minimal Setup (Required)

Yes

Notes (Required)

If you try and build a tall wall all of the wall's below the top row will not connect vertically. This happens even in a minimal setup using Fabric rather than Quilt. (This does not impact the vanilla Minecraft wall blocks that have not been converted to DiagonalWalls blocks)

Vanilla behaviour/Vanilla walls 2024-07-31_10 52 33

DiagonalWalls behaviour/DiagonalWalls walls 2024-07-31_10 58 51

latest.log (Required)

https://gist.github.com/JLUsr/ceb81782573c335041383fe9a83bfc9e

Fuzss commented 2 months ago

That is intentional, the vertical wall block states have been removed to make room for the diagonal block states. That's a technical limitation, the mod page mentions it.

JLUsr commented 2 months ago

It's been a while since I read the mod page, rather than just the change log, and I never actually bothered building walls vertically so I totally glossed over this! Well, this is just another learning moment for me, hopefully I'll remember to re-read mod pages before submitting bug reports. Thank you very much!

SSJ3Bane commented 2 months ago

Everyone seems to be having the same question and getting the same realization... It's a stupid fix, but, an item to replace the block with the original wall variant?

Fuzss commented 2 months ago

Well, I could image that maybe sneak+placing a wall could place the vanilla variant. Or sneak+right clicking a placed wall could convert it. What do you think of that? Maybe even both?

JLUsr commented 2 months ago

Well, I could image that maybe sneak+placing a wall could place the vanilla variant. Or sneak+right clicking a placed wall could convert it. What do you think of that? Maybe even both?

I like this a lot. I am partial to the idea of sneak+placing to avoid accidentally changing the block. That being said, maybe something like sneak+right click with pickaxe or right click with pickaxe (or another tool) like with logs and right clicking with an axe since it's something we do now to change a block and isn't too likely to be done on accident.

You could do the same with diagonal fences, sneak+right click with axe or right click with axe, so that someone could intentionally disconnect their fences from each other for decorative purposes.

SSJ3Bane commented 2 months ago

I think sneak+place for the vanilla version would work best compatability wise, since that usually prevents behaviors, mod devs usually include this. For right clicking, or sneak rc with a tool, off the top of my head, that'd cause a carpenters axe on tetra to destroy wooden blocks. Goofy ahhh wand idea still floats :3

JLUsr commented 2 months ago

For right clicking, or sneak rc with a tool, off the top of my head, that'd cause a carpenters axe on tetra to destroy wooden blocks.

I have an off-topic question here, doesn't that mean that you can't strip logs or wood (the block) with a carpenters axe either? This sounds like the carpenters axe isn't meant for that kind of decor alteration anyway (not trying to debate anything just genuinely curious).

Fuzss commented 2 weeks ago

Just to add to this: In the 1.21+ versions you can use sneak+right click on a placed wall to convert it back to vanilla, so that upwards connections will show again when the walls are not connected diagonally

vinnyg0621 commented 1 week ago

you can even make tall variants for the diagonal wall too!