search

Fuzss / puzzleslib

Why's it called Puzzles you ask? That's the puzzle!
https://www.curseforge.com/minecraft/mc-mods/puzzles-lib
Mozilla Public License 2.0
26 stars 9 forks source link

[Bug]: Performance issues by just doing nothing #140

Open Torathion opened 1 month ago

Torathion commented 1 month ago

Mod Loader (Required)

Fabric

Minecraft Version(s) (Required)

1.21.1

Mod Version(s) (Required)

21.1.18

Other Mods Involved (Required)

Yes

Notes (Required)

I'm testing out a minimal modpack and wanted to install visual workbench, but just having that and this library made my performance (that's already low thanks to my low end pc) worse. I don't know why, but it keeps doing stuff in the background.

Spark logs: Lithium + PuzzlesLib: https://spark.lucko.me/unxojQ2axc Lithium alone: https://spark.lucko.me/Yo4KIAyHfZ Without both (because I realized I don't need Lithium): https://spark.lucko.me/SW9UWUFHi7 PuzzlesLib alone: https://spark.lucko.me/8PEeIZ3Jce

Since I'm still new to all of this, I can't provide much information to why it's acting up on my system.

latest.log (Required)

https://mclo.gs/0QFva4y

Fuzss commented 1 month ago

That's a false flag. Puzzles Lib wraps a vanilla method call and is therefore blamed for the overhead of the vanilla method. Will adjust the implementation so this is no longer the case.

Torathion commented 1 month ago

It's not really a false flag. I can attest with my low end PC that this actually lowers my FPS by 3 - 5 and I get occasionally micro stutters. It's even higher in combination with other mods that I had performance issues with, like Lithium completely crippled my performance from constant 40 -> 15.

Fuzss commented 1 month ago

Feel free to join our Discord for help with improving performance. Definitely check the FAQ channel. https://lunapixel.studio/discord