Open PPMDJ opened 5 months ago
YnwLNE
commented
5 months ago Was just about to suggest this. Additionally instead of relying on swordblockingmechanics:can_perform_sword_blocking, I wonder if there is any way to have the mod detect a modded sword and automatically apply the mechanic with a black/white list. Would fix a lot of incompats with mods like Majrusz's Progressive Difficulty and Tetra
Fuzss
commented
5 months ago swordblockingmechanics:can_perform_sword_blocking includes the vanilla minecraft:swords tag. All mods that add swords should add their swords to that tag. There is no need to add any detection for modded swords.
If a modded sword is missing from minecraft:swords you should report that to the respective mod author. If a modded sword is not included in minecraft:swords on purpose and you still want it to be able to block you or the mod author can include it directly in swordblockingmechanics:can_perform_sword_blocking.
If you report ids for missing modded swords here I can add them to swordblockingmechanics:can_perform_sword_blocking by default.
amzelee
commented
3 weeks ago If a modded sword is not included in minecraft:swords on purpose and you still want it to be able to block you or the mod author can include it directly in swordblockingmechanics:can_perform_sword_blocking.
Hi! I was wondering if you could tell me where this is as I cannot find a config to manually add swordblockingmechanics:can_perform_sword_blocking.
Mod Loader (Optional)
Fabric
Minecraft Version(s) (Optional)
1.20.1
Mod Version(s) (Optional)
No response
Suggestion (Required)
This fantastic mod could be enhanced with a bit extra animation compatibility with first person mod and better combat. While the sword blocking animation still works, it would be cool if the animations had some variety depending on the weapon type used, rather than universally holding the sword/weapon up diagonally like it is currently. Also, when blocking with a weapon, the weapon goes out of view while I'm using the first-person mod. Adjusting the default blocking animation to be a bit more visible to players running with the First Person mod would boost combat immersion!