Fuzss / universalenchants

Better enchantments! Use them on all tools and weapons. Infinity crossbow, or looting trident anyone?
https://www.curseforge.com/minecraft/mc-mods/universal-enchants-forge
Mozilla Public License 2.0
3 stars 3 forks source link

[Crash]: Starting Integrated Server (Modpack) #62

Open xFirefalconx opened 11 months ago

xFirefalconx commented 11 months ago

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.18.2

Mod Version (Required)

v3.1.0

Notes (Required)

  1. Load a game world
  2. It crashes

I was updating a lot of mods in my modpack. When I was done doing so, I figured starting the game is possible, so let's go back to my game world. It can't do that though. I don't think it's a single mod issue, more like a combination, but I don't know which of the many many mods to test on. Is SWEM a highly likely culprit? Shall I try to create a new world to see if the old world is incompatible? I still suspect a bunch of causes, I just thought sharing the report and asking for advice on which mods may be troubling, so I can narrow down further. The Universal Enchants mod gets thrown in the stacktrace veeery early so... is it struggling with Star Worm Equestrian Mod's latest version (1.3.0-15)?

I posted two crash reports because I had two and wonder if they're the same thing, using NEC (not enough crashes).

Crash Report (Required)

https://gist.github.com/xFirefalconx/1b29debf0f025086c9f606a447b6ac71 https://gist.github.com/xFirefalconx/525fb4a1b46cab5762c0dafc10f418dd

latest.log (Optional)

https://gist.github.com/xFirefalconx/90445c47a4c0d504e500246c972fe405

Fuzss commented 11 months ago

SWEM seems to be the issue as one enchantment (swem:galaxy_coat) is missing an EnchantmentCategory (which is what defines what type of item the enchantment can go on).

I'll change Universal Enchants to simply exclude such enchantments from being configurable in a future update. Will be a while still though since I'm currently rewriting the whole mod to allow for more enchantment features to be configurable (like max level).

xFirefalconx commented 11 months ago

Thanks a lot for the fast investigation! I forwarded your information to their dev team, hopefully it'll be fixed soon. I'll see if downgrading either or both mods will temporarily fix it and then update once your new version is out. Would you be so kind to keep me updated on the matter?

Fuzss commented 11 months ago

I'll leave this issue open until the new version is released.

xFirefalconx commented 11 months ago

Tested a temporary fix by downgrading both Puzzles Lib and Universal Enchants - the game doesn't crash anymore. SWEM stayed in its latest one, so I suppose it got to do with the latest UE update's behaviour changes, but all to its time at least it works again for now.

MagnusHJensen commented 11 months ago

SWEM seems to be the issue as one enchantment (swem:galaxy_coat) is missing an EnchantmentCategory (which is what defines what type of item the enchantment can go on).

I'll change Universal Enchants to simply exclude such enchantments from being configurable in a future update. Will be a while still though since I'm currently rewriting the whole mod to allow for more enchantment features to be configurable (like max level).

Heyo, former SWEM dev here. We specifically don't want to put an enchantment category on the enchantment, since it's a very specific enchantment, that needed a custom canEnchant, and not be confused with other EnchantmentCategories. That being said, the enchantment category is an extensible enum, so not sure if a better course of action would be to add a new EnchantmentCategory, that is only used for our enchantment.