search

Fuzss / visualworkbench

Items stay inside of crafting tables and are also rendered on top. It's really fancy!
https://www.curseforge.com/minecraft/mc-mods/visual-workbench
Mozilla Public License 2.0
8 stars 7 forks source link

[Bug]: CraftTweaker Incompatibility #31

Closed TigrottoL9 closed 4 months ago

TigrottoL9 commented 1 year ago

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.19.2

Mod Version (Required)

4.2.4

Notes (Required)

I modified a crafting recipe with the crafttweaker mod.

If i place the ingredients inside the crafting table in the correct position and close the crafting table gui everything is fine, but when i reopen it, the recipe output disappears. CraftingOk CraftingNotOk

A temporary solution is to remove and replace an ingredient in the recipe and the output reappears.

latest.log (Optional)

No response

Darkosto commented 1 year ago

It seems like this issue is caused by using a custom crafting container that is meant to pass method calls to a delegate container: https://github.com/Fuzss/visualworkbench/blob/main/1.20/Common/src/main/java/fuzs/visualworkbench/world/inventory/ForwardingCraftingContainer.java#L13C72-L13C72

Visual Workbench's crafting container is not the container that CraftTweaker or other mods are expecting: https://github.com/jaredlll08/RecipeStages/blob/a347ca2a8138d9ab44b73ac7e45a90f51fa28f2b/src/main/java/com/blamejared/recipestages/recipes/IStagedRecipe.java#L87

This could potentially be solved by making the container extend TransientCraftingContainer instead of just CraftingContainer

Fuzss commented 4 months ago

This has only been fixed for 1.20.4+ yet.