search

FxMorin / carpet-fixes

fabric-carpet extension mod which attempts to fix as many vanilla minecraft bugs as possible. Feel free to add as many fixes as you want! Currently 220+ Fixes!
MIT License
133 stars 21 forks source link

suggestion: remove lightningKillsDropsFix rule #169

Open peow opened 6 months ago

peow commented 6 months ago

the main mod (Carpet) already has this functionality

image https://github.com/gnembon/fabric-carpet/wiki/Current-Available-Settings#lightningkillsdropsfix

image https://github.com/fxmorin/carpet-fixes/wiki/Available-Settings#lightningkillsdropsfix

so they overlap [13:24:30] [main/WARN]: Method overwrite conflict for method_5800 in carpet-fixes.mixins.json:itemFixes.ItemEntity_lightningKillsDropsMixin from mod carpet-fixes, previously written by carpet.mixins.ItemEntityMixin. Skipping method.

FxMorin commented 5 months ago

I wrote the original rule and asked gnembon to remove it, and he never did

peow commented 5 months ago

i see, im sorry