search

FyiurAmron / sortablejs

DokuWiki client-side (JS) plugin for sortable tables.
10 stars 5 forks source link

Does not sort IPv4 & IPv6 addresses anymore #1

Closed mbunkus closed 10 years ago

mbunkus commented 10 years ago

Hey,

it seems like you've replaced the jQuery table sorter plugin with your own version. In the process you've unfortunately not implemented all the types that jQuery's implementation supported. For us sorting IPv4 and IPv6 addresses correctly is paramount, so this is a major regression for us. Please reconsider using jQuery again. Thanks.

mbunkus commented 10 years ago

What I mean by sort correctly:

Correct ordering for some IPv4 examples:

10.93.2.2
10.93.2.19
10.93.2.20
10.93.20.9

Correct ordering for some IPv6 examples:

fd01:123:45::1
fd01:123:45::feed:1
fd01:123:45::feed:10
fd01:123:45::1:0:1
oiv commented 10 years ago

sortablejs never user jQuery sort. Actually never had any special handling for ip address sort either.

FyiurAmron commented 8 years ago

@mbunkus for further reference: if you or anybody else needs support for a currently nonexistent feature (IPv6 sorting being one of them), please consider, as usual with OSS, writing the needed code and submitting a PR for it.