search

FyshOS / fin

A Fyne login manager for linux desktop computers
Other
27 stars 6 forks source link

fix broken coverage tests #14

Closed taigrr closed 2 years ago

taigrr commented 2 years ago

Fixes #13

taigrr commented 2 years ago

These checks have failed, but they are supposed to fail since I didn't increase test coverage and the current coverage is 21%., the threshold previously set was 25%.

andydotxyz commented 2 years ago

25 must have been a copy-paste bug as we use the same checks on multiple repos. Could you update it to 20, then the tests will pass and we can get it merged? :) thanks

taigrr commented 2 years ago

Great, done.

andydotxyz commented 2 years ago

Thanks for this, I will apply the fix to our other repos too :)

taigrr commented 2 years ago

Looks like just textedit has the bug now in FyshOS, but several others in fyne-io: fyne, fynedesk, fyne-x

andydotxyz commented 2 years ago

Thanks, I think they are all fixed now. The list was helpful as I noticed a previous fix that was not applied as well

taigrr commented 2 years ago

image