search

FyshOS / fin

A Fyne login manager for linux desktop computers
Other
27 stars 6 forks source link

adds reboot option #6

Closed taigrr closed 2 years ago

taigrr commented 2 years ago

Addresses #1

If I am not following the proper style guide, please let me know what I would need to change.

taigrr commented 2 years ago

I would like to theme the Shutdown button as ErrorColor and Restart as WarnColor but that would require support from https://github.com/fyne-io/fyne/issues/1861 . I would love to revisit this once that issue is complete.

taigrr commented 2 years ago

@Jacalz I've gone ahead and made the changes you recommended and then squashed the commits.

Jacalz commented 2 years ago

@Jacalz I've gone ahead and made the changes you recommended and then squashed the commits.

Thanks. It is worth noting that we prefer not to force push changes during the review process. It usually breaks the old review comments on GitHub. If the commits need squashed, we can do so when merging.

I can't run this locally at the moment unfortunately but I'll have a look when I can.

andydotxyz commented 2 years ago

Thanks for this work. A couple of thoughts inline - but overall I can't help but shake the feeling that it looks less user friendly now. I know the old dialog did not provide much real information, but just a column of buttons seems scary in some way I think.

shutdown-old reboot

andydotxyz commented 2 years ago

I would like to theme the Shutdown button as ErrorColor and Restart as WarnColor but that would require support from fyne-io/fyne#1861 . I would love to revisit this once that issue is complete.

This isn't really true - you can add any background underneath a button. I could agree with an error colour under shutdown - but I don't think that additional colours for other buttons makes so much sense myself.

taigrr commented 2 years ago

I will continue to use my own fork of this project, but reading through some other pull requests and documentation from the fin + fyne project, it's now clear to me that the goals of the maintainers are very opinionated (in design this is a good thing, not an insult!). These opinions are very different from my own. I have respect for these design opinions, but I feel my own are incompatible.

Thank you for a great project, I will be closing this PR without a merge.

andydotxyz commented 2 years ago

Thanks @taigrr, I understand. I hope that you like the alternative that I proposed in #9

taigrr commented 2 years ago

Yes, this does look good.