FyshOS / fin

A Fyne login manager for linux desktop computers
Other
27 stars 6 forks source link

Use Go's built-in embed package instead of fyne's #7

Closed taigrr closed 1 year ago

taigrr commented 2 years ago

Fyne's generator for creating embedded static resources was a great idea, and necessary at the time of creation, but as of Go 1.16, there's a new standard library API called embed.

I would like to propose fin moves over to that package instead. Benefits include:

I've already implemented this myself, PR incoming.

taigrr commented 2 years ago

This can't be done until Debian Stable includes go 1.16 support to ensure compatibility with FyshOS. The linked PR is closed to avoid clutter, but I will leave this issue open as a reminder when the time comes.

taigrr commented 1 year ago

It's here! Golang v1.19 is now part of debian stable.

andydotxyz commented 1 year ago

Yes this is good news. However I'd recommend holding back until Fyne updates to 1.17 minimum (on develop, will be 2.4.0) - just to avoid surprising developers?

taigrr commented 1 year ago

Yeah that makes sense.