search

FyshOS / fin

A Fyne login manager for linux desktop computers
Other
27 stars 6 forks source link

bundle now uses go embed #8

Closed taigrr closed 1 year ago

taigrr commented 2 years ago

See #7

This PR was created by copying the bundle.go file into a new temporary folder, and writing a new main() which dumped out the image file to my disk. I've moved that file to the img/ directory.

Then, the //go:generate line was replaced with //go:embed as per the documentation.

taigrr commented 2 years ago

That's fine. Go 1.16 is in debian testing right now, it has been since November 15 2021 (12 days ago.)

This PR can remain open until it trickles down to Stable.

Jacalz commented 2 years ago

Given that we are following the stable release of Debian, I think that’s unfortunately going to be at least two years away :/

taigrr commented 2 years ago

I see. Huge bummer. Guess I'll reopen this at some point in the future then.

Jacalz commented 2 years ago

I see. Huge bummer.

Yeah, I know :/

I'm not very happy with it either. I think they just make things worse with not updating it. So much work goes into backporting security patches to years old releases, work that could have been better spent elsewhere. But oh well, it is what it is.

andydotxyz commented 2 years ago

Yeah it is a shame, but as Fyne is focused on ease of use for developers and end users alike we have to assume that coders are using their OS standard package manager. Until there is a real reason to break that assumption let's stick with it.

andydotxyz commented 1 year ago

As I mentioned on the issue this is technically ok now, but maybe we should hold back until Fyne upstream drops 1.14 in the next release.

Jacalz commented 1 year ago

Sounds sensible. We can also target Go 1.17 in that case instead of 1.16

Jacalz commented 1 year ago

This should be able to land after you resolve the conflicts :)

taigrr commented 1 year ago

Alright, I think the conflicts look resolved to me, let me know if there's anything else

I've also created a similar PR in FyshOS/backgrounds#3 now that it's where the backgrounds ended up

Jacalz commented 1 year ago

The tests seem to be failing. Would you mind having a look at them?

taigrr commented 1 year ago

@Jacalz I had to update the go.mod to 1.20 and then back to 1.17 to make sure the extra linting rules for 1.20 (which are more strict than 1.17) were applied. Should be good to go