coveralls
commented
1 year ago Pull Request Test Coverage Report for Build 4019595106
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage remained the same at 29.24%
| Totals | |
|---|---|
| Change from base Build 3989644708: | 0.0% |
| Covered Lines: | 1543 |
| Relevant Lines: | 5277 |
Description:
Using a multi-monitor setup of GNOME [1]; The Xephyr embedded Fynedesk session (called by
make embed) reliably crashes the host window-manager. GNOME recovers from this -- Xephyr launches and connects to Fynedesk, but this results in Fyne defined elements like the 'search box', 'application menu', and any resulting apps to be launched on the host and not in said embedded session.This PR makes two edits to the 'embed' section of the Makefile; Namely, by dropping the first explicit deceleration of the DISPLAY variable. This should be set by one's host anyways & hard-coding it seems to cause problems at least in this given usecase. And the second edit, is switching the given display server port to a less often used value; It was suggested we use :2 or :5. Ultimately, :5 was chosen because it seems less likely to conflict with anything.
This is officially "works for me territory" & certainly I don't know the edges of Xephyr or Xorg specific tech in-general. So if there's anything that looks fishy (<_<) about this, let me know!
Fixes #NA Discussed On Discord.
Checklist: NA?
[1] Tested In GNOME 43.2, on Debian 12 Bookworm (Currently 'Testing').