Continuing work from #248

FyshOS / fynedesk

A full desktop environment for Linux/Unix using Fyne

https://fyne.io/fynedesk/

Other

1.02k stars 47 forks source link

Continuing work from #248 #249

Closed taigrr closed 1 year ago

taigrr commented 1 year ago

Commits and rebasing made things a bit messy and GH auto-closed the PR. I'm reopening it here. (ref: #248)

taigrr commented 1 year ago

@andydotxyz this looks to still be requiring 1.14 in the tests even after merging in the changes.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5395855545

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 29.161%

Totals
Change from base Build 5365239568:	0.0%
Covered Lines:	1540
Relevant Lines:	5281

💛 - Coveralls

andydotxyz commented 1 year ago

Apologies, I have fixed the settings now

andydotxyz commented 1 year ago

This looks good - can you do a sanity check for file size before and after, just to make sure it's still happy. I don't think there are lots of big files here but good to know.

taigrr commented 1 year ago

File size of the built fynedesk executable you mean?

Before merge: 26M / 26232352 After merge: 26M / 26233928

the change of 1576 bytes is probably explainable by the change in dependencies between the two versions