FyshOS / movies

Fyne based movie file player
Other
26 stars 7 forks source link

Request to advance the implementation to sync up with latest version of reisen #3

Closed dharanict closed 1 year ago

dharanict commented 1 year ago

The latest version of Reisen package is v0.1.7.

It now provides support for streaming video. Please refer to this issue of reisen: https://github.com/zergon321/reisen/issues/19.

Here is a request to update FyshOS/movies to be in sync with reisen v0.1.7.

dharanict commented 1 year ago

Specifically, request support for RTMP. Here is the directory: https://github.com/zergon321/reisen/tree/master/examples/rtmp

dharanict commented 1 year ago

I tinkered main.go, ignored .mp4 filename argument and used code like this:

    path := "rtmp://127.0.0.1/live/stream"
    name := path
    err := p.open(path)
    if false {
            fmt.Printf("name %s\n", name)
    }

Also, I introduced NetworkInitialize() call:

// Starts reading samples and frames // of the media file. func (p *player) open(fname string) error { // For RTMP stream reading. err := reisen.NetworkInitialize() if err != nil { return err } defer reisen.NetworkDeinitialize() ...

I used the latest reisen package (I did "replace" in go.mod).

With this, I was able to play the streaming video.

It would be nice if FyshOS/movies code is also updated to latest version of reisen. Hence the request.

Hope this helps.