G-GCELL / api-server

0 stars 0 forks source link

[Refactor/#21] SSE 연결 기능 수정 - [merged] #69

Closed TaeYeongKwak closed 1 year ago

TaeYeongKwak commented 1 year ago

Merges refactor/#21 -> dev

📋 구현 내용

SSE 연결 기능 테스트 후 일부 코드 수정

🔍 테스트 케이스

📢 코멘트

@tommysgit @AnTaeWook @muyongKim

TaeYeongKwak commented 1 year ago

In GitLab by @tommysgit on Feb 9, 2023, 11:12

approved this merge request

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 9, 2023, 11:19

approved this merge request

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 9, 2023, 11:34

Commented on src/main/java/com/gabia/weat/gcellapiserver/service/MessageService.java line 45

로그 작성 시 formatter {}를 사용하면 실제 로그 출력 시에 문자열 연산을 수행하므로 더 효율적으로 수행될 수 있습니다!

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 9, 2023, 11:35

approved this merge request

TaeYeongKwak commented 1 year ago

changed this line in version 2 of the diff

TaeYeongKwak commented 1 year ago

added 1 commit

Compare with previous version

TaeYeongKwak commented 1 year ago

해당 부분 변경 완료하였습니다.

TaeYeongKwak commented 1 year ago

resolved all threads

TaeYeongKwak commented 1 year ago

enabled an automatic merge when the pipeline for 567ecf8cd3b1cb4fa96c968070fe88aee90d8be5 succeeds

TaeYeongKwak commented 1 year ago

mentioned in commit 85144aab00c0701ae602bfe3521e6178e5483435