G-GCELL / api-server

0 stars 0 forks source link

[Feat/#26] Log 출력 기능 구현 - [merged] #83

Closed TaeYeongKwak closed 1 year ago

TaeYeongKwak commented 1 year ago

Merges feat/#26 -> dev

📋 구현 내용

요청에 대한 Log 출력 기능 구현

🔍 테스트 케이스

📢 코멘트

@tommysgit @AnTaeWook @muyongKim

TaeYeongKwak commented 1 year ago

added 32 commits

Compare with previous version

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 16, 2023, 13:41

LGTM :thumbsup:

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 16, 2023, 13:41

approved this merge request

TaeYeongKwak commented 1 year ago

In GitLab by @tommysgit on Feb 16, 2023, 13:43

Commented on src/main/java/com/gabia/weat/gcellapiserver/dto/log/LogFormatFactory.java line 17

해당 변수를 정적 변수로 선언한 이유가 무엇인가요?

TaeYeongKwak commented 1 year ago

해당 변수는 traceId의 길이를 설정하기 위한 값인데 후에 길이가 변경될 수 도 있을 것 같아 관리하기 편하도록 일단 정적 변수로 선언하였습니다.

TaeYeongKwak commented 1 year ago

In GitLab by @tommysgit on Feb 16, 2023, 13:55

Commented on src/main/java/com/gabia/weat/gcellapiserver/dto/log/LogFormatFactory.java line 17

클래스 안에서만 사용된다면 빼는게 어떤가 싶어서 얘기하였습니다.

TaeYeongKwak commented 1 year ago

changed this line in version 3 of the diff

TaeYeongKwak commented 1 year ago

added 2 commits

Compare with previous version

TaeYeongKwak commented 1 year ago

해당 부분 변경 완료하였습니다.

TaeYeongKwak commented 1 year ago

resolved all threads

TaeYeongKwak commented 1 year ago

In GitLab by @tommysgit on Feb 16, 2023, 14:02

resolved all threads

TaeYeongKwak commented 1 year ago

In GitLab by @tommysgit on Feb 16, 2023, 14:08

approved this merge request

TaeYeongKwak commented 1 year ago

mentioned in commit 1e7928292ef4b669cbfcb3e9837babb28e9b5c99