search

G-GCELL / api-server

0 stars 0 forks source link

[Feat/#36] API μ„œλ²„ MessageWrapperDto κ΅¬ν˜„ - [merged] #87

Closed TaeYeongKwak closed 1 year ago

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 09:54

Merges feat/#36 -> dev

πŸ“‹Β κ΅¬ν˜„ λ‚΄μš©

λ‘œκΉ… 및 μ—λŸ¬ νŠΈλž˜ν‚Ήμ„ μœ„ν•œ trace IDλ₯Ό ν¬ν•¨ν•˜μ—¬ MessageDto의 wrapper 클래슀 κ΅¬ν˜„

FileCreateRequestDto μœ νš¨μ„± 검증 μ—λŸ¬ ν•΄κ²°

μ—‘μ…€ 파일 생성 μ‹œ, μ‚¬μš©μžκ°€ 포함할 μΉΌλŸΌμ„ 지정할 수 μžˆλ„λ‘ DTO에 ν•„λ“œ μΆ”κ°€

πŸ” ν…ŒμŠ€νŠΈ μΌ€μ΄μŠ€

πŸ“’ μ½”λ©˜νŠΈ

@tommysgit @AnTaeWook @TaeYeongKwak

TaeYeongKwak commented 1 year ago

μ˜€νƒ€μΈ 것 κ°™μŠ΅λ‹ˆλ‹€. μˆ˜μ • λΆ€νƒλ“œλ €μš”.

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 09:58

Commented on src/test/java/com/gabia/weat/gcellapiserver/service/producer/FileCreateRequestProducerTest.java line 29

changed this line in version 2 of the diff

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 09:58

added 2 commits

Compare with previous version

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 09:58

Commented on src/test/java/com/gabia/weat/gcellapiserver/service/producer/FileCreateRequestProducerTest.java line 29

μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€. κ°μ‚¬ν•©λ‹ˆλ‹€!

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 10:06

added 1 commit

Compare with previous version

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 21, 2023, 10:06

Commented on src/main/java/com/gabia/weat/gcellapiserver/dto/FileDto.java line 31

λ‚ μ§œ 비ꡐ μ–΄λ…Έν…Œμ΄μ…˜λ„ μΆ”κ°€ν•˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!
(dateMin > dateMax, endDate > startDate)

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 10:12

Commented on src/main/java/com/gabia/weat/gcellapiserver/dto/FileDto.java line 31

ν•΄λ‹Ή 뢀뢄은 λ”°λ‘œ refactor 이슈λ₯Ό νŒŒμ„œ 진행해야 ν•  것 κ°™μŠ΅λ‹ˆλ‹€πŸ‘

TaeYeongKwak commented 1 year ago

approved this merge request

TaeYeongKwak commented 1 year ago

In GitLab by @tommysgit on Feb 21, 2023, 10:13

approved this merge request

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 21, 2023, 10:13

approved this merge request

TaeYeongKwak commented 1 year ago

In GitLab by @AnTaeWook on Feb 21, 2023, 10:14

resolved all threads

TaeYeongKwak commented 1 year ago

In GitLab by @muyongKim on Feb 21, 2023, 10:14

mentioned in commit 390b604c695058bcda16aa1ef70d462c57be975b